AM335x MLO images broken

AM335x MLO images broken

[Teresa Gamez]

Hello Sascha,

since 

commit d1ec6fb0c9bb66939e85964c2f5214b117c78ecf
Author: Sascha Hauer <s.hauer@pengutronix.de>
Date:   Mon Jul 7 14:13:14 2014 +0200

    ARM: OMAP: Do not show MLO/SPI image options with OMAP_MULTI_BOARDS


the creation of a proper MLO image is not working any more. When I run 
make am335x_mlo_defconfig && make I get:
..
images built:
barebox-am33xx-phytec-phycore.img
barebox-am33xx-beaglebone.img

instead of the expected

barebox-am33xx-phytec-phycore-mlo.img
barebox-am33xx-beaglebone-mlo.img

and they also won't work.

Teresa


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: AM335x MLO images broken

[Sascha Hauer]

On Wed, Jul 09, 2014 at 05:50:12PM +0200, Teresa Gamez wrote:
> Hello Sascha,
> 
> since 
> 
> commit d1ec6fb0c9bb66939e85964c2f5214b117c78ecf
> Author: Sascha Hauer <s.hauer@pengutronix.de>
> Date:   Mon Jul 7 14:13:14 2014 +0200
> 
>     ARM: OMAP: Do not show MLO/SPI image options with OMAP_MULTI_BOARDS
> 
> 
> the creation of a proper MLO image is not working any more. When I run 
> make am335x_mlo_defconfig && make I get:
> ..
> images built:
> barebox-am33xx-phytec-phycore.img
> barebox-am33xx-beaglebone.img
> 
> instead of the expected
> 
> barebox-am33xx-phytec-phycore-mlo.img
> barebox-am33xx-beaglebone-mlo.img
> 
> and they also won't work.

Looks like a side effect of:

| commit d1ec6fb0c9bb66939e85964c2f5214b117c78ecf
| Author: Sascha Hauer <s.hauer@pengutronix.de>
| Date:   Mon Jul 7 14:13:14 2014 +0200
| 
|     ARM: OMAP: Do not show MLO/SPI image options with OMAP_MULTI_BOARDS
|     
|     The MLO/SPI image options have no effect with OMAP_MULTI_BOARDS
|     enabled, so do not show them.
|     
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

I haven't looked whether there's a better solution than reverting the
commit.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: AM335x MLO images broken

[Sascha Hauer]

On Thu, Jul 10, 2014 at 09:37:37AM +0200, Rolf Evers-Fischer wrote:
> Hello Sascha,
> 
> Sascha Hauer <s.hauer@...> writes:
> 
> > Looks like a side effect of:
> > 
> > | commit d1ec6fb0c9bb66939e85964c2f5214b117c78ecf
> > | Author: Sascha Hauer <s.hauer@...>
> > | Date:   Mon Jul 7 14:13:14 2014 +0200
> > | 
> > |     ARM: OMAP: Do not show MLO/SPI image options with OMAP_MULTI_BOARDS
> > |     
> > |     The MLO/SPI image options have no effect with OMAP_MULTI_BOARDS
> > |     enabled, so do not show them.
> > |     
> > |     Signed-off-by: Sascha Hauer <s.hauer@...>
> > 
> > I haven't looked whether there's a better solution than reverting the
> > commit.
> > 
> 
> your patch disables generation of MLO/SPI image, if OMAP_MULTI_BOARDS is 
> enabled. But shouldn't it be vice versa? I mean, both boards 
> (MACH_BEAGLEBONE and MACH_PCM051), which are dependend on 
> OMAP_MULTI_BOARDS, need a working MLO image. From my point of view it 
> makes sense to ENable the OMAP_BUILD_IFT along with OMAP_MULTI_BOARDS.

Indeed. I'll just revert the patch.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: AM335x MLO images broken

[Rolf Evers-Fischer]

Hello Sascha,

Sascha Hauer <s.hauer@...> writes:

> Looks like a side effect of:
> 
> | commit d1ec6fb0c9bb66939e85964c2f5214b117c78ecf
> | Author: Sascha Hauer <s.hauer@...>
> | Date:   Mon Jul 7 14:13:14 2014 +0200
> | 
> |     ARM: OMAP: Do not show MLO/SPI image options with OMAP_MULTI_BOARDS
> |     
> |     The MLO/SPI image options have no effect with OMAP_MULTI_BOARDS
> |     enabled, so do not show them.
> |     
> |     Signed-off-by: Sascha Hauer <s.hauer@...>
> 
> I haven't looked whether there's a better solution than reverting the
> commit.
> 

your patch disables generation of MLO/SPI image, if OMAP_MULTI_BOARDS is 
enabled. But shouldn't it be vice versa? I mean, both boards 
(MACH_BEAGLEBONE and MACH_PCM051), which are dependend on 
OMAP_MULTI_BOARDS, need a working MLO image. From my point of view it 
makes sense to ENable the OMAP_BUILD_IFT along with OMAP_MULTI_BOARDS.

Best regards,
 Rolf

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox