mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Holger Schurig <holgerschurig@gmail.com>
To: barebox@lists.infradead.org
Subject: [PATCH 3/3] sandbox: work around missing of_add_memory_bank()
Date: Tue, 22 Jul 2014 09:57:22 +0200	[thread overview]
Message-ID: <1406015842-20754-4-git-send-email-holgerschurig@gmail.de> (raw)

From: Holger Schurig <holgerschurig@gmail.com>

The goal of "make ARCH=sandbox allyesconfig && make all" is not to
generate a sensible barebox that you'd use. The goal is to create
as much code coverage as possible, so that you see compiler warnings
are can send barebox throught a static checker.

Therefore this simple band-aid to compile drivers/of/base.c wouldn't
create a working device tree implementation, but it will compile.

Signed-off-by: Holger Schurig <holgerschurig@gmail.com>
---
 drivers/of/base.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index c440a69..69d9b09 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1713,8 +1713,10 @@ int of_add_memory(struct device_node *node, bool dump)
 			continue;
 		}
 
+#ifndef CONFIG_SANDBOX
 		of_add_memory_bank(node, dump, n,
 				res.start, resource_size(&res));
+#endif
 		n++;
 	}
 
-- 
1.8.5.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2014-07-22  7:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22  7:57 Holger Schurig [this message]
2014-07-22  8:32 ` Lucas Stach
2014-07-22  8:39   ` Holger Schurig
2014-07-22  8:50     ` Lucas Stach
2014-07-22  8:59       ` Holger Schurig
2014-07-22  9:09         ` Holger Schurig
2014-07-22  9:43           ` Lucas Stach
2014-07-22 10:25             ` Holger Schurig
2014-07-22 10:52               ` Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406015842-20754-4-git-send-email-holgerschurig@gmail.de \
    --to=holgerschurig@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox