From: Juergen Borleis <jbe@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH v2] envfs: provide an intentional way to ignore an existing external environment
Date: Thu, 31 Jul 2014 12:38:59 +0200 [thread overview]
Message-ID: <1406803143-27630-1-git-send-email-jbe@pengutronix.de> (raw)
Some use cases are using the barebox's built-in environment only, but still
provide an external environment store to save a modified environment (for
development purposes for example).
In this case barebox works as intended even if the external store is empty
and thus invalid. But even if it is an intentional behavior, barebox emits an
error message due to an invalid content in the external store (CRC error).
Because this error message will confuse a new user (how to know if this error
message is important or can be ignored?) and it is a bad style to ship
intentionally working systems with error messages, the following change set
adds an "empty environment" feature to barebox.
This change set adds a new option to the saveenv command which will write an
zeroed environment without content. But it will be marked as a placeholder and
thus should be "ignored" and barebox falls back to its built-in default
environment.
With this feature we now get:
- if the environment store is empty, we still see an error message and
barebox still falls back to its built-in default environment
- if the environment store contains the new zeroed environment, there
will be no error message but barebox falls back to its built-in default
environment as well ("intentional behaviour")
- if the environment store contains a regular environment (modified compared
to the built-in one) barebox will continue to use it and ignores its
built-in default environment instead.
This is v2 of this change set.
- using a forced built-in default environment is handled inside the
envfs_load() function. Suggested by Sascha.
- the new flag to force the built-in default environment uses a more
descriptive name. Suggested by Sascha.
Comments are welcome.
Juergen
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2014-07-31 10:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 10:38 Juergen Borleis [this message]
2014-07-31 10:39 ` [PATCH 1/4] saveenv: make clear how to use the command's parameters Juergen Borleis
2014-07-31 10:39 ` [PATCH 2/4] envfs: provide an intentional way to ignore an existing external environment Juergen Borleis
2014-07-31 10:39 ` [PATCH 3/4] envfs: change API to be able to forward special flags into the envfs superblock Juergen Borleis
2014-07-31 10:39 ` [PATCH 4/4] saveenv: provide a zeroed/empty/ignore environment Juergen Borleis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406803143-27630-1-git-send-email-jbe@pengutronix.de \
--to=jbe@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox