mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Teresa Gámez" <t.gamez@phytec.de>
To: barebox@lists.infradead.org
Subject: [PATCHv3 5/5] commands: add of_display_timings
Date: Tue, 30 Sep 2014 13:15:30 +0200	[thread overview]
Message-ID: <1412075730-5946-5-git-send-email-t.gamez@phytec.de> (raw)
In-Reply-To: <1412075730-5946-1-git-send-email-t.gamez@phytec.de>

A lot of boards use display-timings nodes to define the timings of one or more
displays. This command makes it possible to list and select displays which are
defined in a device tree.

Signed-off-by: Teresa Gámez <t.gamez@phytec.de>
---
Changes v3:
- removed overwriting of root node
- using now for_each_node_by_name_from and of_parse_phandle_from
- eliminated ret variable

Changes v2:
- removed cast
- added free(ftd)
- freed root

 commands/Kconfig              |  15 ++++
 commands/Makefile             |   1 +
 commands/of_display_timings.c | 164 ++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 180 insertions(+)
 create mode 100644 commands/of_display_timings.c

diff --git a/commands/Kconfig b/commands/Kconfig
index 3a49baf..0563e63 100644
--- a/commands/Kconfig
+++ b/commands/Kconfig
@@ -1973,6 +1973,21 @@ config CMD_OF_PROPERTY
 	  [00 11 22 .. nn]  - byte stream
 	  If the value does not start with '<' or '[' it is interpreted as string
 
+config CMD_OF_DISPLAY_TIMINGS
+	tristate
+	select OFTREE
+	prompt "of_display_timings"
+	help
+	  List and select display timings
+
+	  Usage: of_display_timings [-lS] [-s path] [-f dtb]
+
+	  Options:
+		  -l		list path of all available display-timings
+		  -S		list path of all selected display-timings
+		  -s path	select display-timings and register oftree fixup
+		  -f dtb	work on dtb. Has no effect on -s option
+
 config CMD_OFTREE
 	tristate
 	select OFTREE
diff --git a/commands/Makefile b/commands/Makefile
index 52b6137..f5ecbe6 100644
--- a/commands/Makefile
+++ b/commands/Makefile
@@ -76,6 +76,7 @@ obj-$(CONFIG_CMD_OFTREE)	+= oftree.o
 obj-$(CONFIG_CMD_OF_PROPERTY)	+= of_property.o
 obj-$(CONFIG_CMD_OF_NODE)	+= of_node.o
 obj-$(CONFIG_CMD_OF_DUMP)	+= of_dump.o
+obj-$(CONFIG_CMD_OF_DISPLAY_TIMINGS)	+= of_display_timings.o
 obj-$(CONFIG_CMD_MAGICVAR)	+= magicvar.o
 obj-$(CONFIG_CMD_IOMEM)		+= iomemport.o
 obj-$(CONFIG_CMD_LINUX_EXEC)	+= linux_exec.o
diff --git a/commands/of_display_timings.c b/commands/of_display_timings.c
new file mode 100644
index 0000000..ccf2db0
--- /dev/null
+++ b/commands/of_display_timings.c
@@ -0,0 +1,164 @@
+/*
+ * of_display_timings.c - list and select display_timings
+ *
+ * Copyright (c) 2014 Teresa Gámez <t.gamez@phytec.de> PHYTEC Messtechnik GmbH
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <common.h>
+#include <filetype.h>
+#include <libfile.h>
+#include <of.h>
+#include <command.h>
+#include <malloc.h>
+#include <complete.h>
+#include <asm/byteorder.h>
+#include <getopt.h>
+#include <linux/err.h>
+#include <string.h>
+
+static int of_display_timing(struct device_node *root, void *timingpath)
+{
+	int ret = 0;
+	struct device_node *display;
+
+	display = of_find_node_by_path_from(root, timingpath);
+	if (!display) {
+		pr_err("Path to display-timings is not vaild.\n");
+		ret = -EINVAL;
+		goto out;
+	}
+
+	ret = of_set_property_to_child_phandle(display, "native-mode");
+	if (ret)
+		pr_err("Could not set display\n");
+out:
+	return ret;
+}
+
+static int do_of_display_timings(int argc, char *argv[])
+{
+	int opt;
+	int list = 0;
+	int selected = 0;
+	struct device_node *root = NULL;
+	struct device_node *display = NULL;
+	struct device_node *timings = NULL;
+	char *timingpath = NULL;
+	char *dtbfile = NULL;
+
+	while ((opt = getopt(argc, argv, "sS:lf:")) > 0) {
+		switch (opt) {
+		case 'l':
+			list = 1;
+			break;
+		case 'f':
+			dtbfile = optarg;
+			break;
+		case 's':
+			selected = 1;
+			break;
+		case 'S':
+			timingpath = xzalloc(strlen(optarg) + 1);
+			strcpy(timingpath, optarg);
+			break;
+		default:
+			return COMMAND_ERROR_USAGE;
+		}
+	}
+
+	/* Check if external dtb given */
+	if (dtbfile) {
+		void *fdt;
+		size_t size;
+
+		fdt = read_file(dtbfile, &size);
+		if (!fdt) {
+			pr_err("unable to read %s: %s\n", dtbfile,
+				strerror(errno));
+			return -errno;
+		}
+
+		if (file_detect_type(fdt, size) != filetype_oftree) {
+			pr_err("%s is not a oftree file.\n", dtbfile);
+			free(fdt);
+			return -EINVAL;
+		}
+
+		root = of_unflatten_dtb(fdt);
+
+		free(fdt);
+
+		if (IS_ERR(root))
+			return PTR_ERR(root);
+
+	} else {
+		root = of_get_root_node();
+	}
+
+	if (list) {
+		int found = 0;
+		const char *node = "display-timings";
+
+		for_each_node_by_name_from(display, root, node) {
+			for_each_child_of_node(display, timings) {
+				printf("%s\n", timings->full_name);
+				found = 1;
+			}
+		}
+
+		if (!found)
+			printf("No display-timings found.\n");
+	}
+
+	if (selected) {
+		int found = 0;
+		const char *node = "display-timings";
+
+		for_each_node_by_name_from(display, root, node) {
+			timings = of_parse_phandle_from(display, root,
+							"native-mode", 0);
+			if (!timings)
+				continue;
+
+			printf("%s\n", timings->full_name);
+			found = 1;
+		}
+
+		if (!found)
+			printf("No selected display-timings found.\n");
+	}
+
+	if (timingpath)
+		of_register_fixup(of_display_timing, timingpath);
+
+	return 0;
+}
+
+BAREBOX_CMD_HELP_START(of_display_timings)
+BAREBOX_CMD_HELP_TEXT("Options:")
+BAREBOX_CMD_HELP_OPT("-l",  "list path of all available display-timings\n")
+BAREBOX_CMD_HELP_OPT("-s",  "list path of all selected display-timings\n")
+BAREBOX_CMD_HELP_OPT("-S path",  "select display-timings and register oftree fixup\n")
+BAREBOX_CMD_HELP_OPT("-f dtb",  "work on dtb. Has no effect on -s option\n")
+BAREBOX_CMD_HELP_END
+
+BAREBOX_CMD_START(of_display_timings)
+	.cmd	= do_of_display_timings,
+	BAREBOX_CMD_DESC("print and select display-timings")
+	BAREBOX_CMD_OPTS("[-ls] [-S path] [-f dtb]")
+	BAREBOX_CMD_GROUP(CMD_GRP_MISC)
+	BAREBOX_CMD_COMPLETE(devicetree_file_complete)
+	BAREBOX_CMD_HELP(cmd_of_display_timings_help)
+BAREBOX_CMD_END
-- 
1.9.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2014-09-30 11:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-30 11:15 [PATCHv3 1/5] of: base: Add for_each_node_by_name_from Teresa Gámez
2014-09-30 11:15 ` [PATCHv3 2/5] of: base: Add of_find_node_by_phandle_from Teresa Gámez
2014-09-30 11:15 ` [PATCHv3 3/5] of: base: Add of_parse_phandle_from Teresa Gámez
2014-09-30 11:15 ` [PATCHv3 4/5] of: Added of_set_property_to_child_phandle Teresa Gámez
2014-09-30 11:15 ` Teresa Gámez [this message]
2014-10-01  6:13 ` [PATCHv3 1/5] of: base: Add for_each_node_by_name_from Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412075730-5946-5-git-send-email-t.gamez@phytec.de \
    --to=t.gamez@phytec.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox