From: Antony Pavlov <antonynpavlov@gmail.com>
To: barebox@lists.infradead.org
Subject: [RFC] clocksource: dummy: don't show message on first cs read
Date: Fri, 28 Nov 2014 16:07:32 +0300 [thread overview]
Message-ID: <1417180052-16824-1-git-send-email-antonynpavlov@gmail.com> (raw)
In the commit
commit 96cae61eba199b9c3f5451f293cf60db2b535164
Author: Sascha Hauer <s.hauer@pengutronix.de>
Date: Tue Sep 30 08:25:55 2014 +0200
clock: Add a variable with the first timestamp after startup
For measuring the startup time it's useful to save the first
timestamp after the clocksource has been registered.
the behaviour of clocksource subsystem is changed: every registered
clocksource is called at least once. So the dummy clocksource (if enabled)
_ALWAYS_ prints a confusing 'Using dummy clocksource' warning.
This patch fixes the situation: now the 'Using dummy clocksource'
warning is printed only if the dummy clocksource is called second time.
Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
drivers/clocksource/dummy.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/clocksource/dummy.c b/drivers/clocksource/dummy.c
index 96f9b6e..9a42305 100644
--- a/drivers/clocksource/dummy.c
+++ b/drivers/clocksource/dummy.c
@@ -25,8 +25,11 @@ static uint64_t dummy_cs_read(void)
{
static int first;
- if (!first) {
+ if (first == 1) {
pr_warn("Warning: Using dummy clocksource\n");
+ first = 2;
+ }
+ if (!first) {
first = 1;
}
--
2.1.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2014-11-28 13:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 13:07 Antony Pavlov [this message]
2014-12-01 6:31 ` Sascha Hauer
2014-12-01 10:01 ` Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417180052-16824-1-git-send-email-antonynpavlov@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox