mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: barebox@lists.infradead.org
Subject: [PATCH] commands: fix a warning in help.c
Date: Tue, 13 Jan 2015 15:24:33 +0900	[thread overview]
Message-ID: <1421130273-6507-1-git-send-email-yamada.m@jp.panasonic.com> (raw)

Fix the following warning:

commands/help.c: In function ‘list_group’:
commands/help.c:57:4: warning: format not a string literal and
no format arguments [-Wformat-security]
    printf(cmdtp->name);
    ^

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---

 commands/help.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/commands/help.c b/commands/help.c
index 8985335..6e61bde 100644
--- a/commands/help.c
+++ b/commands/help.c
@@ -54,7 +54,7 @@ static void list_group(int verbose, const char *grpname, uint32_t group)
 				printf(", ");
 				pos += 2;
 			}
-			printf(cmdtp->name);
+			puts(cmdtp->name);
 			pos += len;
 		}
 	}
-- 
1.9.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2015-01-13  6:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-13  6:24 Masahiro Yamada [this message]
2015-01-13  7:56 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421130273-6507-1-git-send-email-yamada.m@jp.panasonic.com \
    --to=yamada.m@jp.panasonic.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox