mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 1/3] common: console_console: put functions under correct ifdef
@ 2015-01-18 20:57 Lucas Stach
  2015-01-18 20:57 ` [PATCH 2/3] usb: musb-dsps: select OFDEVICE Lucas Stach
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Lucas Stach @ 2015-01-18 20:57 UTC (permalink / raw)
  To: barebox

So they aren't build when no console support is selected.

Fixes:
In function `console_get_by_dev': undefined reference to `console_list'

Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
 common/console_common.c | 70 ++++++++++++++++++++++++-------------------------
 1 file changed, 35 insertions(+), 35 deletions(-)

diff --git a/common/console_common.c b/common/console_common.c
index df1b085982ad..d88e678aadb5 100644
--- a/common/console_common.c
+++ b/common/console_common.c
@@ -247,6 +247,41 @@ int vprintf(const char *fmt, va_list args)
 }
 EXPORT_SYMBOL(vprintf);
 
+struct console_device *console_get_by_dev(struct device_d *dev)
+{
+	struct console_device *cdev;
+
+	for_each_console(cdev) {
+		if (cdev->dev == dev)
+			return cdev;
+	}
+
+	return NULL;
+}
+EXPORT_SYMBOL(console_get_by_dev);
+
+/*
+ * @brief returns current used console device
+ *
+ * @return console device which is registered with CONSOLE_STDIN and
+ * CONSOLE_STDOUT
+ */
+struct console_device *console_get_first_active(void)
+{
+	struct console_device *cdev;
+	/*
+	 * Assumption to have BOTH CONSOLE_STDIN AND STDOUT in the
+	 * same output console
+	 */
+	for_each_console(cdev) {
+		if ((cdev->f_active & (CONSOLE_STDIN | CONSOLE_STDOUT)))
+			return cdev;
+	}
+
+	return NULL;
+}
+EXPORT_SYMBOL(console_get_first_active);
+
 #endif /* !CONFIG_CONSOLE_NONE */
 
 int fprintf(int file, const char *fmt, ...)
@@ -291,38 +326,3 @@ int fputc(int fd, char c)
 	return 0;
 }
 EXPORT_SYMBOL(fputc);
-
-struct console_device *console_get_by_dev(struct device_d *dev)
-{
-	struct console_device *cdev;
-
-	for_each_console(cdev) {
-		if (cdev->dev == dev)
-			return cdev;
-	}
-
-	return NULL;
-}
-EXPORT_SYMBOL(console_get_by_dev);
-
-/*
- * @brief returns current used console device
- *
- * @return console device which is registered with CONSOLE_STDIN and
- * CONSOLE_STDOUT
- */
-struct console_device *console_get_first_active(void)
-{
-	struct console_device *cdev;
-	/*
-	 * Assumption to have BOTH CONSOLE_STDIN AND STDOUT in the
-	 * same output console
-	 */
-	for_each_console(cdev) {
-		if ((cdev->f_active & (CONSOLE_STDIN | CONSOLE_STDOUT)))
-			return cdev;
-	}
-
-	return NULL;
-}
-EXPORT_SYMBOL(console_get_first_active);
-- 
2.1.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/3] usb: musb-dsps: select OFDEVICE
  2015-01-18 20:57 [PATCH 1/3] common: console_console: put functions under correct ifdef Lucas Stach
@ 2015-01-18 20:57 ` Lucas Stach
  2015-01-18 20:57 ` [PATCH 3/3] arm: board: virt2real: build lowlevel in proper target Lucas Stach
  2015-01-19  7:47 ` [PATCH 1/3] common: console_console: put functions under correct ifdef Sascha Hauer
  2 siblings, 0 replies; 4+ messages in thread
From: Lucas Stach @ 2015-01-18 20:57 UTC (permalink / raw)
  To: barebox

Fixes:
In function `dsps_probe': undefined reference to `of_usb_get_dr_mode'

Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
 drivers/usb/musb/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
index e0a1139bc0d0..b795f30275cf 100644
--- a/drivers/usb/musb/Kconfig
+++ b/drivers/usb/musb/Kconfig
@@ -5,6 +5,7 @@ if USB_MUSB
 
 config USB_MUSB_DSPS
 	tristate
+	select OFDEVICE
 
 config USB_MUSB_AM335X
 	tristate "AM335x USB support"
-- 
2.1.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 3/3] arm: board: virt2real: build lowlevel in proper target
  2015-01-18 20:57 [PATCH 1/3] common: console_console: put functions under correct ifdef Lucas Stach
  2015-01-18 20:57 ` [PATCH 2/3] usb: musb-dsps: select OFDEVICE Lucas Stach
@ 2015-01-18 20:57 ` Lucas Stach
  2015-01-19  7:47 ` [PATCH 1/3] common: console_console: put functions under correct ifdef Sascha Hauer
  2 siblings, 0 replies; 4+ messages in thread
From: Lucas Stach @ 2015-01-18 20:57 UTC (permalink / raw)
  To: barebox

Fixes build with PBL enabled.

Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
 arch/arm/boards/virt2real/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boards/virt2real/Makefile b/arch/arm/boards/virt2real/Makefile
index b2f44bba1b5b..01c7a259e9a5 100644
--- a/arch/arm/boards/virt2real/Makefile
+++ b/arch/arm/boards/virt2real/Makefile
@@ -1 +1,2 @@
-obj-y += lowlevel.o board.o
+obj-y += board.o
+lwl-y += lowlevel.o
-- 
2.1.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/3] common: console_console: put functions under correct ifdef
  2015-01-18 20:57 [PATCH 1/3] common: console_console: put functions under correct ifdef Lucas Stach
  2015-01-18 20:57 ` [PATCH 2/3] usb: musb-dsps: select OFDEVICE Lucas Stach
  2015-01-18 20:57 ` [PATCH 3/3] arm: board: virt2real: build lowlevel in proper target Lucas Stach
@ 2015-01-19  7:47 ` Sascha Hauer
  2 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2015-01-19  7:47 UTC (permalink / raw)
  To: Lucas Stach; +Cc: barebox

On Sun, Jan 18, 2015 at 09:57:02PM +0100, Lucas Stach wrote:
> So they aren't build when no console support is selected.
> 
> Fixes:
> In function `console_get_by_dev': undefined reference to `console_list'
> 
> Signed-off-by: Lucas Stach <dev@lynxeye.de>

Applied all, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-01-19  7:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-18 20:57 [PATCH 1/3] common: console_console: put functions under correct ifdef Lucas Stach
2015-01-18 20:57 ` [PATCH 2/3] usb: musb-dsps: select OFDEVICE Lucas Stach
2015-01-18 20:57 ` [PATCH 3/3] arm: board: virt2real: build lowlevel in proper target Lucas Stach
2015-01-19  7:47 ` [PATCH 1/3] common: console_console: put functions under correct ifdef Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox