From: "Eric Bénard" <eric@eukrea.com>
To: s.hauer@pengutronix.de
Cc: barebox@lists.infradead.org
Subject: [PATCH 2/3] dhcp: fix request packet
Date: Thu, 29 Jan 2015 00:37:33 +0100 [thread overview]
Message-ID: <1422488254-18414-2-git-send-email-eric@eukrea.com> (raw)
In-Reply-To: <1422488254-18414-1-git-send-email-eric@eukrea.com>
we are not supposed to fill ciaddr, yiaddr and siaddr in the request packet.
Signed-off-by: Eric Bénard <eric@eukrea.com>
---
net/dhcp.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/net/dhcp.c b/net/dhcp.c
index 78440dd..7f9b989 100644
--- a/net/dhcp.c
+++ b/net/dhcp.c
@@ -559,9 +559,7 @@ static void dhcp_send_request_packet(struct bootp *bp_offer)
bp->bp_hops = 0;
/* FIXME what is this? */
// bp->bp_secs = htons(get_timer(0) / CFG_HZ);
- net_copy_ip(&bp->bp_ciaddr, &bp_offer->bp_ciaddr); /* both in network byte order */
- net_copy_ip(&bp->bp_yiaddr, &bp_offer->bp_yiaddr);
- net_copy_ip(&bp->bp_siaddr, &bp_offer->bp_siaddr);
+
/*
* RFC3046 requires Relay Agents to discard packets with
* nonzero and offered giaddr
--
1.9.3
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-01-28 23:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 23:37 [PATCH 1/3] dhcp: fix request packet's requested IP option Eric Bénard
2015-01-28 23:37 ` Eric Bénard [this message]
2015-01-28 23:37 ` [PATCH 3/3] dhcp: fix request packet's seconds elapsed Eric Bénard
2015-01-28 23:42 ` [PATCH v2 1/3] dhcp: fix request packet's requested IP option Eric Bénard
2015-01-29 7:40 ` Sascha Hauer
2015-01-30 8:01 ` [PATCH " Jean-Christophe PLAGNIOL-VILLARD
2015-01-30 8:13 ` Eric Bénard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422488254-18414-2-git-send-email-eric@eukrea.com \
--to=eric@eukrea.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox