mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH v2] imd: provide dummy imd_command_setenv
Date: Mon, 09 Feb 2015 14:14:15 +0100	[thread overview]
Message-ID: <1423487655.10796.0.camel@pengutronix.de> (raw)
In-Reply-To: <1418813891-24169-1-git-send-email-l.stach@pengutronix.de>

Ping. :)

Am Mittwoch, den 17.12.2014, 11:58 +0100 schrieb Lucas Stach:
> If CONFIG_CMD_IMD is not set there is no imd_command_setenv in the
> barebox binary that can be linked to. Although the whole imd infrastructure
> will be removed by the linker later in the build process as soon as it
> figures out that nothing inside barebox is using it, we still have to
> provide a dummy function to keep the build going.
> 
> Fixes:
> In function `imd_command': undefined reference to `imd_command_setenv'
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> v2: move dummy to correct location
> ---
>  common/imd.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/common/imd.c b/common/imd.c
> index 2c837d6f256e..f84e34473e69 100644
> --- a/common/imd.c
> +++ b/common/imd.c
> @@ -22,6 +22,13 @@
>  #include <getopt.h>
>  #include <malloc.h>
>  #include <fs.h>
> +
> +#ifndef CONFIG_CMD_IMD
> +int imd_command_setenv(const char *variable_name, const char *value)
> +{
> +	return -ENOSYS;
> +}
> +#endif
>  #endif
>  
>  /*

-- 
Pengutronix e.K.             | Lucas Stach                 |
Industrial Linux Solutions   | http://www.pengutronix.de/  |


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2015-02-09 13:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-17 10:58 Lucas Stach
2015-02-09 13:14 ` Lucas Stach [this message]
2015-02-10  9:39   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423487655.10796.0.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox