From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 5/6] mtd: nand-bb: Fix test for bad block when reading
Date: Tue, 10 Feb 2015 10:03:33 +0100 [thread overview]
Message-ID: <1423559014-3783-6-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1423559014-3783-1-git-send-email-s.hauer@pengutronix.de>
in nand_bb_read() 'offset' contains the virtual position on the device,
but we have to test for a bad block on the raw physical position, so
use bb->offset instead of offset
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/mtd/nand/nand-bb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/nand-bb.c b/drivers/mtd/nand/nand-bb.c
index f134635..c8f6988 100644
--- a/drivers/mtd/nand/nand-bb.c
+++ b/drivers/mtd/nand/nand-bb.c
@@ -62,7 +62,7 @@ static ssize_t nand_bb_read(struct cdev *cdev, void *buf, size_t count,
if (max <= 0)
break;
- if (mtd_block_isbad(bb->mtd, offset)) {
+ if (mtd_block_isbad(bb->mtd, bb->offset)) {
printf("skipping bad block at 0x%08llx\n", bb->offset);
bb->offset += bb->mtd->erasesize;
continue;
--
2.1.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-02-10 9:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 9:03 [PATCH v2] nand-bb fixes Sascha Hauer
2015-02-10 9:03 ` [PATCH 1/6] mtd: nand: omap: Fix OMAP_ECC_BCH8_CODE_HW ecc mode Sascha Hauer
2015-02-10 9:03 ` [PATCH 2/6] mtd: Fix allowing to erase bad blocks on partitions Sascha Hauer
2015-02-10 9:03 ` [PATCH 3/6] mtd: nand-bb: Fix accesses beyond device Sascha Hauer
2015-02-10 9:03 ` [PATCH 4/6] mtd: nand-bb: fix erasing bb devices with bad blocks Sascha Hauer
2015-02-10 9:03 ` Sascha Hauer [this message]
2015-02-10 9:03 ` [PATCH 6/6] mtd: nand-bb: Also print raw position in debug messages Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423559014-3783-6-git-send-email-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox