From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: barebox@lists.infradead.org
Subject: [PATCH 2/4] gpio: Return -EPROBE_DEFER on gpio_get_num()
Date: Fri, 10 Apr 2015 03:02:44 +0200 [thread overview]
Message-ID: <1428627766-17178-3-git-send-email-sebastian.hesselbarth@gmail.com> (raw)
In-Reply-To: <1428627766-17178-1-git-send-email-sebastian.hesselbarth@gmail.com>
GPIO drivers can be registered quite late in registration process
causing dependant devices to fail probing. If we know gpio_get_num
will be called with a non-NULL device, return -EPROBE_DEFER instead
of -ENODEV to allow re-probing later.
Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
---
Cc: barebox@lists.infradead.org
---
drivers/gpio/gpiolib.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 611e41ea5606..1f57c76ec16d 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -292,12 +292,15 @@ int gpio_get_num(struct device_d *dev, int gpio)
{
struct gpio_chip *chip;
+ if (!dev)
+ return -ENODEV;
+
list_for_each_entry(chip, &chip_list, list) {
if (chip->dev == dev)
return chip->base + gpio;
}
- return -ENODEV;
+ return -EPROBE_DEFER;
}
#ifdef CONFIG_CMD_GPIO
--
2.1.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-04-10 1:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 1:02 [PATCH 0/4] Introduce deferred probing Sebastian Hesselbarth
2015-04-10 1:02 ` [PATCH 1/4] base: " Sebastian Hesselbarth
2015-04-13 6:54 ` Sascha Hauer
2015-04-13 14:26 ` Sebastian Hesselbarth
2015-04-10 1:02 ` Sebastian Hesselbarth [this message]
2015-04-10 1:02 ` [PATCH 3/4] OF: gpio: Silence error message on -EPROBE_DEFER Sebastian Hesselbarth
2015-04-10 1:02 ` [PATCH 4/4] led: gpio: Properly deal with deferred probing Sebastian Hesselbarth
2015-04-13 8:14 ` [PATCH 0/4] Introduce " Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428627766-17178-3-git-send-email-sebastian.hesselbarth@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox