From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ns.lynxeye.de ([87.118.118.114] helo=lynxeye.de) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YgTAg-0002xT-A4 for barebox@lists.infradead.org; Fri, 10 Apr 2015 07:16:11 +0000 Message-ID: <1428650112.2182.1.camel@lynxeye.de> From: Lucas Stach Date: Fri, 10 Apr 2015 09:15:12 +0200 In-Reply-To: <1428627714-17077-2-git-send-email-sebastian.hesselbarth@gmail.com> References: <1428627714-17077-1-git-send-email-sebastian.hesselbarth@gmail.com> <1428627714-17077-2-git-send-email-sebastian.hesselbarth@gmail.com> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/4] pci: fix device registration for directly attached devices To: Sebastian Hesselbarth Cc: barebox@lists.infradead.org Am Freitag, den 10.04.2015, 03:01 +0200 schrieb Sebastian Hesselbarth: > Commit b8a1bb1dd215770670108fe5b0de0e5e137bf8fd > ("pci: defer device registration until after bridge setup") > removed pci_register_device() from setup_device() to allow > bridges to be registered before attached sub-devices. > > This breaks normal registration for devices that are not > connected through a bridge. Fix this by calling pci_register_device() > for normal devices again. > Signed-off-by: Sebastian Hesselbarth NACK: This again breaks devices that are connected through a bridge if the bridge configuration is invalid at startup. There is already a patch on the list which should fix this problem "pci: make sure to activate devices on the root bus". Could you please test this instead? > --- > Cc: barebox@lists.infradead.org > Cc: Lucas Stach > --- > drivers/pci/pci.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index d6e95c3ec894..c633d138ca66 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -344,6 +344,7 @@ unsigned int pci_scan_bus(struct pci_bus *bus) > dev->rom_address = (l == 0xffffffff) ? 0 : l; > > setup_device(dev, 6); > + pci_register_device(dev); > break; > case PCI_HEADER_TYPE_BRIDGE: > setup_device(dev, 2); _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox