[PATCH] firmware: socfpga: Add necessary dependency to Kconfig

[PATCH] firmware: socfpga: Add necessary dependency to Kconfig

[Andrey Smirnov]

---
 drivers/firmware/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
index 15465fe..710b500 100644
--- a/drivers/firmware/Kconfig
+++ b/drivers/firmware/Kconfig
@@ -13,5 +13,5 @@ config FIRMWARE_ALTERA_SERIAL
 config FIRMWARE_ALTERA_SOCFPGA
 	bool "Altera SoCFPGA fpga loader"
 	depends on ARCH_SOCFPGA
-
+	select FIRMWARE
 endmenu
-- 
2.1.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] firmware: socfpga: Add necessary dependency to Kconfig

[Sascha Hauer]

On Mon, Apr 13, 2015 at 05:11:30AM -0700, Andrey Smirnov wrote:
> ---
>  drivers/firmware/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This patch lacks a signed-off-by. Could you resend it?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] firmware: socfpga: Add necessary dependency to Kconfig

[Andrey Smirnov]

On Tue, Apr 14, 2015 at 11:39 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Mon, Apr 13, 2015 at 05:11:30AM -0700, Andrey Smirnov wrote:
>> ---
>>  drivers/firmware/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> This patch lacks a signed-off-by. Could you resend it?

I figured tat since this was just a one line in a build configuration
file it would be too trivial for copyright assignment, but I can add
the signed-off-by line in the next version of the patch.


>
> Sascha
>
> --
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] firmware: socfpga: Add necessary dependency to Kconfig

[Sascha Hauer]

On Tue, Apr 14, 2015 at 12:47:46PM -0700, Andrey Smirnov wrote:
> On Tue, Apr 14, 2015 at 11:39 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > On Mon, Apr 13, 2015 at 05:11:30AM -0700, Andrey Smirnov wrote:
> >> ---
> >>  drivers/firmware/Kconfig | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > This patch lacks a signed-off-by. Could you resend it?
> 
> I figured tat since this was just a one line in a build configuration
> file it would be too trivial for copyright assignment, but I can add
> the signed-off-by line in the next version of the patch.

Indeed it's trivial and nobody will doubt this was your work, but where
should I draw the line? Always insisting on the signed-off-by helps us
not thinking about this topic anymore.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox