From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: barebox@lists.infradead.org
Subject: [PATCH v2 3/6] OF: gpio: Silence error message on -EPROBE_DEFER
Date: Wed, 15 Apr 2015 00:53:17 +0200 [thread overview]
Message-ID: <1429052000-20647-4-git-send-email-sebastian.hesselbarth@gmail.com> (raw)
In-Reply-To: <1429052000-20647-1-git-send-email-sebastian.hesselbarth@gmail.com>
With deferred probing, -EPROBE_DEFER is not worth spilling an error.
Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
---
Changelog:
v1->v2:
- Also return early on gpio_get_num() == -EPROBE_DEFER
Cc: barebox@lists.infradead.org
---
drivers/of/of_gpio.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/of/of_gpio.c b/drivers/of/of_gpio.c
index 6738a220a5a3..dc8ae2277641 100644
--- a/drivers/of/of_gpio.c
+++ b/drivers/of/of_gpio.c
@@ -32,12 +32,14 @@ int of_get_named_gpio_flags(struct device_node *np, const char *propname,
dev = of_find_device_by_node(out_args.np);
if (!dev) {
- pr_err("%s: unable to find device of node %s\n",
- __func__, out_args.np->full_name);
- return -ENODEV;
+ pr_debug("%s: unable to find device of node %s\n",
+ __func__, out_args.np->full_name);
+ return -EPROBE_DEFER;
}
ret = gpio_get_num(dev, out_args.args[0]);
+ if (ret == -EPROBE_DEFER)
+ return ret;
if (ret < 0) {
pr_err("%s: unable to get gpio num of device %s: %d\n",
__func__, dev_name(dev), ret);
--
2.1.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-04-14 22:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 22:53 [PATCH v2 0/6] Introduce deferred probing Sebastian Hesselbarth
2015-04-14 22:53 ` [PATCH v2 1/6] base: " Sebastian Hesselbarth
2015-04-14 22:53 ` [PATCH v2 2/6] gpio: Return -EPROBE_DEFER on gpio_get_num() Sebastian Hesselbarth
2015-04-14 22:53 ` Sebastian Hesselbarth [this message]
2015-04-14 22:53 ` [PATCH v2 4/6] led: gpio: Properly deal with deferred probing Sebastian Hesselbarth
2015-04-14 22:53 ` [PATCH v2 5/6] led: gpio: Free GPIOs on unregister() Sebastian Hesselbarth
2015-04-14 22:53 ` [PATCH v2 6/6] gpio: orion: Convert to platform_driver Sebastian Hesselbarth
2015-04-17 5:24 ` [PATCH v2 0/6] Introduce deferred probing Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429052000-20647-4-git-send-email-sebastian.hesselbarth@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox