[PATCH] net: e1000: add HAS_DMA dependency

[PATCH] net: e1000: add HAS_DMA dependency

[Antony Pavlov]

The e1000 driver uses the dma coherent functions
and thus can only be build for architectures implementing them.

Here is mips malta build error log:

  drivers/built-in.o: In function `e1000_transmit':
  drivers/net/e1000.c:(.text.e1000_transmit+0x80): undefined reference to
  `dma_sync_single_for_device'
  drivers/built-in.o: In function `e1000_poll':
  drivers/net/e1000.c:(.text.e1000_poll+0x60): undefined reference to
  `dma_sync_single_for_cpu'

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
 drivers/net/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 41f033f..b723a12 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -79,6 +79,7 @@ config DRIVER_NET_DM9K
 config DRIVER_NET_E1000
 	bool "Intel e1000 ethernet driver"
 	depends on PCI
+	depends on HAS_DMA
 	select PHYLIB
 	help
 	  This is a driver for the Gigabit Ethernet PCI network cards based on
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] net: e1000: add HAS_DMA dependency

[Sascha Hauer]

On Tue, Apr 28, 2015 at 05:59:41PM +0300, Antony Pavlov wrote:
> The e1000 driver uses the dma coherent functions
> and thus can only be build for architectures implementing them.
> 
> Here is mips malta build error log:
> 
>   drivers/built-in.o: In function `e1000_transmit':
>   drivers/net/e1000.c:(.text.e1000_transmit+0x80): undefined reference to
>   `dma_sync_single_for_device'
>   drivers/built-in.o: In function `e1000_poll':
>   drivers/net/e1000.c:(.text.e1000_poll+0x60): undefined reference to
>   `dma_sync_single_for_cpu'
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
>  drivers/net/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox