From: Lucas Stach <dev@lynxeye.de>
To: barebox@lists.infradead.org
Subject: [PATCH 3/3] PCI: imx6: simplify config access code
Date: Wed, 29 Apr 2015 21:59:48 +0200 [thread overview]
Message-ID: <1430337588-11998-3-git-send-email-dev@lynxeye.de> (raw)
In-Reply-To: <1430337588-11998-1-git-send-email-dev@lynxeye.de>
The PCI core fills in the primary bus number, so there is no
need to walk up the PCI hierarchy in the driver manually.
Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
drivers/pci/pcie-designware.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/pci/pcie-designware.c b/drivers/pci/pcie-designware.c
index 4edaede..4962a19 100644
--- a/drivers/pci/pcie-designware.c
+++ b/drivers/pci/pcie-designware.c
@@ -350,13 +350,6 @@ static void dw_pcie_prog_viewport_io_outbound(struct pcie_port *pp)
dw_pcie_writel_rc(pp, PCIE_ATU_ENABLE, PCIE_ATU_CR2);
}
-struct pci_bus *get_parent_bus(struct pci_bus *bus)
-{
- struct pci_dev *bridge = container_of(bus->parent, struct pci_dev, dev);
-
- return bridge->bus;
-}
-
static int dw_pcie_rd_other_conf(struct pcie_port *pp, struct pci_bus *bus,
u32 devfn, int where, int size, u32 *val)
{
@@ -367,7 +360,7 @@ static int dw_pcie_rd_other_conf(struct pcie_port *pp, struct pci_bus *bus,
PCIE_ATU_FUNC(PCI_FUNC(devfn));
address = where & ~0x3;
- if (get_parent_bus(bus)->number == pp->root_bus_nr) {
+ if (bus->primary == pp->root_bus_nr) {
dw_pcie_prog_viewport_cfg0(pp, busdev);
ret = dw_pcie_cfg_read(pp->va_cfg0_base + address, where, size,
val);
@@ -392,7 +385,7 @@ static int dw_pcie_wr_other_conf(struct pcie_port *pp, struct pci_bus *bus,
PCIE_ATU_FUNC(PCI_FUNC(devfn));
address = where & ~0x3;
- if (get_parent_bus(bus)->number == pp->root_bus_nr) {
+ if (bus->primary == pp->root_bus_nr) {
dw_pcie_prog_viewport_cfg0(pp, busdev);
ret = dw_pcie_cfg_write(pp->va_cfg0_base + address, where, size,
val);
--
2.1.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-04-29 20:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 19:59 [PATCH 1/3] PCI: register and active bridge device before proceeding to scan Lucas Stach
2015-04-29 19:59 ` [PATCH 2/3] PCI: fill in bus primary field Lucas Stach
2015-04-29 19:59 ` Lucas Stach [this message]
2015-05-01 6:38 ` [PATCH 1/3] PCI: register and active bridge device before proceeding to scan Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430337588-11998-3-git-send-email-dev@lynxeye.de \
--to=dev@lynxeye.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox