mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] net: fec: Fix RGMII-ID
@ 2015-04-30 13:01 Markus Pargmann
  2015-05-01  6:38 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Markus Pargmann @ 2015-04-30 13:01 UTC (permalink / raw)
  To: barebox

RGMII-ID just defines transmitter internal delays. Otherwise it is the
same as RGMII. As the differences only influence the behaviour of the
phy, the fec driver should handle it the same way as RGMII.

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
 drivers/net/fec_imx.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/fec_imx.c b/drivers/net/fec_imx.c
index c1fa1517da81..54095e7b7ab7 100644
--- a/drivers/net/fec_imx.c
+++ b/drivers/net/fec_imx.c
@@ -309,7 +309,10 @@ static int fec_init(struct eth_device *dev)
 		}
 	}
 
-	if (fec->interface == PHY_INTERFACE_MODE_RGMII)
+	if (fec->interface == PHY_INTERFACE_MODE_RGMII ||
+	    fec->interface == PHY_INTERFACE_MODE_RGMII_ID ||
+	    fec->interface == PHY_INTERFACE_MODE_RGMII_TXID ||
+	    fec->interface == PHY_INTERFACE_MODE_RGMII_RXID)
 		rcntl |= 1 << 6;
 
 	writel(rcntl, fec->regs + FEC_R_CNTRL);
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: fec: Fix RGMII-ID
  2015-04-30 13:01 [PATCH] net: fec: Fix RGMII-ID Markus Pargmann
@ 2015-05-01  6:38 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2015-05-01  6:38 UTC (permalink / raw)
  To: Markus Pargmann; +Cc: barebox

On Thu, Apr 30, 2015 at 03:01:46PM +0200, Markus Pargmann wrote:
> RGMII-ID just defines transmitter internal delays. Otherwise it is the
> same as RGMII. As the differences only influence the behaviour of the
> phy, the fec driver should handle it the same way as RGMII.
> 
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
>  drivers/net/fec_imx.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Applied, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-05-01  6:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-30 13:01 [PATCH] net: fec: Fix RGMII-ID Markus Pargmann
2015-05-01  6:38 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox