From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pd0-x234.google.com ([2607:f8b0:400e:c02::234]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Yp1rj-0004nY-Cd for barebox@lists.infradead.org; Sun, 03 May 2015 21:55:59 +0000 Received: by pdbnk13 with SMTP id nk13so146470165pdb.0 for ; Sun, 03 May 2015 14:55:37 -0700 (PDT) From: Andrey Smirnov Date: Sun, 3 May 2015 14:55:22 -0700 Message-Id: <1430690125-2257-1-git-send-email-andrew.smirnov@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: [PATCH v2 1/8] imx-image: Correctly fill image size in prepended header To: barebox@lists.infradead.org Cc: Andrey Smirnov If called with '-b' option 'imx-image' tool prepends barebox header to the image, but the tool does not fill the data at image size offset correctly. Fix that. Signed-off-by: Andrey Smirnov --- This patch supercedes the one sent earlier titled: "[PATCH 1/8] Makefile.lib: Fix i.MX image size after generation" scripts/imx/Makefile | 2 ++ scripts/imx/imx-image.c | 12 ++++++++++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/scripts/imx/Makefile b/scripts/imx/Makefile index be0b490..ee0acc1 100644 --- a/scripts/imx/Makefile +++ b/scripts/imx/Makefile @@ -6,5 +6,7 @@ always := $(hostprogs-y) HOSTCFLAGS_imx-usb-loader.o = `pkg-config --cflags libusb-1.0` HOSTLOADLIBES_imx-usb-loader = `pkg-config --libs libusb-1.0` +HOSTCFLAGS_imx-image.o = -I$(srctree) + imx-usb-loader-objs := imx-usb-loader.o imx-image-objs := imx-image.o diff --git a/scripts/imx/imx-image.c b/scripts/imx/imx-image.c index 25ea4d8..c0181df 100644 --- a/scripts/imx/imx-image.c +++ b/scripts/imx/imx-image.c @@ -27,6 +27,8 @@ #include #include +#include + #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0])) #define offsetof(TYPE, MEMBER) __builtin_offsetof(TYPE, MEMBER) #define roundup(x, y) ((((x) + ((y) - 1)) / (y)) * (y)) @@ -92,8 +94,11 @@ static int add_header_v1(void *buf, int offset, uint32_t loadaddr, uint32_t imag struct imx_flash_header *hdr; int dcdsize = curdcd * sizeof(uint32_t); - if (add_barebox_header) + if (add_barebox_header) { + uint32_t *psize = buf + ARM_HEAD_SIZE_OFFSET; memcpy(buf, bb_header, sizeof(bb_header)); + *psize = imagesize; + } buf += offset; hdr = buf; @@ -178,8 +183,11 @@ static int add_header_v2(void *buf, int offset, uint32_t loadaddr, uint32_t imag struct imx_flash_header_v2 *hdr; int dcdsize = curdcd * sizeof(uint32_t); - if (add_barebox_header) + if (add_barebox_header) { + uint32_t *psize = buf + ARM_HEAD_SIZE_OFFSET; memcpy(buf, bb_header, sizeof(bb_header)); + *psize = imagesize; + } buf += offset; hdr = buf; -- 2.1.4 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox