[PATCH] login: fix broken login command

[PATCH] login: fix broken login command

[Hubert Feurstein]

It was possible to login with ctrl-c or an empty password. This bug was
introduced by the recent digest changes in common/password.c (e49a47fb).
The function check_passwd returns now also negative error codes which were
not correctly handled in do_login.

Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
---
 commands/login.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/commands/login.c b/commands/login.c
index 210eb20..bf5085c 100644
--- a/commands/login.c
+++ b/commands/login.c
@@ -71,7 +71,7 @@ static int do_login(int argc, char *argv[])
 			run_command(timeout_cmd);
 		}
 
-		if (check_passwd(passwd, passwd_len))
+		if (check_passwd(passwd, passwd_len) == 1)
 			return 0;
 	} while(1);
 
-- 
2.4.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] login: fix broken login command

[Sascha Hauer]

On Wed, Jun 17, 2015 at 03:02:53PM +0200, Hubert Feurstein wrote:
> It was possible to login with ctrl-c or an empty password. This bug was
> introduced by the recent digest changes in common/password.c (e49a47fb).
> The function check_passwd returns now also negative error codes which were
> not correctly handled in do_login.
> 
> Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
> ---
>  commands/login.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox