[PATCH] state: use name of device node as name, if alias is not available

[PATCH] state: use name of device node as name, if alias is not available

[Marc Kleine-Budde]

Wihtout this patch, when using more than one state device an alias is
mandatory, otherwise the there will be two state devices with the name state.

This patch fixes the limitation by using the device node's name if no alias is
defined.

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 drivers/misc/state.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/state.c b/drivers/misc/state.c
index f3e366480fa2..7a3303264206 100644
--- a/drivers/misc/state.c
+++ b/drivers/misc/state.c
@@ -37,7 +37,7 @@ static int state_probe(struct device_d *dev)
 
 	alias = of_alias_get(np);
 	if (!alias)
-		alias = "state";
+		alias = np->name;
 
 	state = state_new_from_node(alias, np);
 	if (IS_ERR(state))
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] state: use name of device node as name, if alias is not available

[Sascha Hauer]

On Fri, Jul 03, 2015 at 01:49:41PM +0200, Marc Kleine-Budde wrote:
> Wihtout this patch, when using more than one state device an alias is
> mandatory, otherwise the there will be two state devices with the name state.

Are there really two devices? I hope there's a -EEXIST somewhere...

> 
> This patch fixes the limitation by using the device node's name if no alias is
> defined.

The node name is not necessarily unique. Also you might end up with
state names like "state@0" which probably also is not what we want.
Maybe making the alias mandatory for multiple state devices is not the
worst behaviour.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox