From: Jan Luebbe <jluebbe@debian.org>
To: barebox@lists.infradead.org
Subject: [PATCH 2/4] i2c: only use set_scl for recovery after calling prepare_recovery
Date: Wed, 8 Jul 2015 15:29:16 +0200 [thread overview]
Message-ID: <1436362158-24488-3-git-send-email-jluebbe@debian.org> (raw)
In-Reply-To: <1436362158-24488-1-git-send-email-jluebbe@debian.org>
set_scl may be ineffective before calling the driver specific
prepare_recovery callback.
Signed-off-by: Jan Luebbe <jluebbe@debian.org>
---
drivers/i2c/i2c.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/i2c.c b/drivers/i2c/i2c.c
index e350ac5..39837fe 100644
--- a/drivers/i2c/i2c.c
+++ b/drivers/i2c/i2c.c
@@ -299,6 +299,9 @@ static int i2c_generic_recovery(struct i2c_adapter *adap)
if (bri->prepare_recovery)
bri->prepare_recovery(adap);
+ bri->set_scl(adap, val);
+ ndelay(RECOVERY_NDELAY);
+
/*
* By this time SCL is high, as we need to give 9 falling-rising edges
*/
@@ -329,7 +332,6 @@ static int i2c_generic_recovery(struct i2c_adapter *adap)
int i2c_generic_scl_recovery(struct i2c_adapter *adap)
{
- adap->bus_recovery_info->set_scl(adap, 1);
return i2c_generic_recovery(adap);
}
--
2.1.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-07-08 13:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 13:29 i2c bus recovery support Jan Luebbe
2015-07-08 13:29 ` [PATCH 1/4] i2c: add bus recovery infrastructure Jan Luebbe
2015-07-13 6:47 ` Sascha Hauer
2015-07-08 13:29 ` Jan Luebbe [this message]
2015-07-08 13:29 ` [PATCH 3/4] i2c-omap: clear ARDY twice Jan Luebbe
2015-07-08 13:29 ` [PATCH 4/4] i2c-omap: add bus recovery support Jan Luebbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436362158-24488-3-git-send-email-jluebbe@debian.org \
--to=jluebbe@debian.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox