mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Alexander Shiyan <shc_work@mail.ru>
To: barebox@lists.infradead.org
Subject: [PATCH] mci: mmci: Fix status flags check
Date: Fri,  7 Aug 2015 11:39:55 +0300	[thread overview]
Message-ID: <1438936795-5608-1-git-send-email-shc_work@mail.ru> (raw)

Data transfer procedures should check _DATA_ flags instead of _CMD_.
---
 drivers/mci/mmci.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/mci/mmci.c b/drivers/mci/mmci.c
index 608cac1..9d1e858 100644
--- a/drivers/mci/mmci.c
+++ b/drivers/mci/mmci.c
@@ -269,18 +269,18 @@ static int read_bytes(struct mci_host *mci, char *dest, unsigned int blkcount, u
 		xfercount -= len;
 		dest += len;
 		status = mmci_readl(host, MMCISTATUS);
-		status_err = status & (MCI_CMDCRCFAIL | MCI_DATATIMEOUT |
-			       MCI_RXOVERRUN);
+		status_err = status & (MCI_DATACRCFAIL | MCI_DATATIMEOUT |
+			     MCI_RXOVERRUN);
 	} while(xfercount && !status_err);
 
 	status_err = status &
-		(MCI_CMDCRCFAIL | MCI_DATATIMEOUT | MCI_DATABLOCKEND |
+		(MCI_DATACRCFAIL | MCI_DATATIMEOUT | MCI_DATABLOCKEND |
 		 MCI_RXOVERRUN);
 
 	while (!status_err) {
 		status = mmci_readl(host, MMCISTATUS);
 		status_err = status &
-			(MCI_CMDCRCFAIL | MCI_DATATIMEOUT | MCI_DATABLOCKEND |
+			(MCI_DATACRCFAIL | MCI_DATATIMEOUT | MCI_DATABLOCKEND |
 			 MCI_RXOVERRUN);
 	}
 
@@ -288,7 +288,7 @@ static int read_bytes(struct mci_host *mci, char *dest, unsigned int blkcount, u
 		dev_err(host->hw_dev, "Read data timed out, xfercount: %u, status: 0x%08X\n",
 			xfercount, status);
 		return -ETIMEDOUT;
-	} else if (status & MCI_CMDCRCFAIL) {
+	} else if (status & MCI_DATACRCFAIL) {
 		dev_err(host->hw_dev, "Read data bytes CRC error: 0x%x\n", status);
 		return -EILSEQ;
 	} else if (status & MCI_RXOVERRUN) {
@@ -351,7 +351,7 @@ static int write_bytes(struct mci_host *mci, char *dest, unsigned int blkcount,
 	dev_dbg(host->hw_dev, "write_bytes: blkcount=%u blksize=%u\n", blkcount, blksize);
 
 	status = mmci_readl(host, MMCISTATUS);
-	status_err = status & (MCI_CMDCRCFAIL | MCI_DATATIMEOUT);
+	status_err = status & (MCI_DATACRCFAIL | MCI_DATATIMEOUT);
 
 	do {
 		len = mmci_pio_write(host, dest, xfercount, status);
@@ -359,11 +359,11 @@ static int write_bytes(struct mci_host *mci, char *dest, unsigned int blkcount,
 		dest += len;
 
 		status = mmci_readl(host, MMCISTATUS);
-		status_err = status & (MCI_CMDCRCFAIL | MCI_DATATIMEOUT);
+		status_err = status & (MCI_DATACRCFAIL | MCI_DATATIMEOUT);
 	} while (!status_err && xfercount);
 
 	status_err = status &
-		(MCI_CMDCRCFAIL | MCI_DATATIMEOUT | MCI_DATABLOCKEND);
+		(MCI_DATACRCFAIL | MCI_DATATIMEOUT | MCI_DATABLOCKEND);
 	while (!status_err) {
 		status = mmci_readl(host, MMCISTATUS);
 		status_err = status &
@@ -374,7 +374,7 @@ static int write_bytes(struct mci_host *mci, char *dest, unsigned int blkcount,
 		dev_err(host->hw_dev, "Write data timed out, xfercount:%u,status:0x%08X\n",
 		       xfercount, status);
 		return -ETIMEDOUT;
-	} else if (status & MCI_CMDCRCFAIL) {
+	} else if (status & MCI_DATACRCFAIL) {
 		dev_err(host->hw_dev, "Write data CRC error\n");
 		return -EILSEQ;
 	}
-- 
2.3.6


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2015-08-07  8:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-07  8:39 Alexander Shiyan [this message]
2015-08-19 14:47 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438936795-5608-1-git-send-email-shc_work@mail.ru \
    --to=shc_work@mail.ru \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox