From: Lucas Stach <l.stach@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 3/4] video: simple-panel: mode support depends on I2C and EDID
Date: Wed, 12 Aug 2015 10:46:44 +0200 [thread overview]
Message-ID: <1439369205-26787-3-git-send-email-l.stach@pengutronix.de> (raw)
In-Reply-To: <1439369205-26787-1-git-send-email-l.stach@pengutronix.de>
Reading modes from EDID EEPROMs requires both I2C and EDID support to
be available. As the simple panel driver is also useful without mode
reading support, only built it in if the requirements are met.
Fixes:
In function `simple_panel_get_modes':
simple-panel.c:88: undefined reference to `of_find_i2c_adapter_by_node'
simple-panel.c:91: undefined reference to `edid_read_i2c'
simple-panel.c:95: undefined reference to `edid_to_display_timings'
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
drivers/video/simple-panel.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/video/simple-panel.c b/drivers/video/simple-panel.c
index dceedc60c31d..3dd760b38538 100644
--- a/drivers/video/simple-panel.c
+++ b/drivers/video/simple-panel.c
@@ -82,7 +82,8 @@ static int simple_panel_get_modes(struct simple_panel *panel, struct display_tim
{
int ret = -ENOENT;
- if (panel->ddc_node) {
+ if (panel->ddc_node && IS_ENABLED(CONFIG_DRIVER_VIDEO_EDID) &&
+ IS_ENABLED(CONFIG_I2C)) {
struct i2c_adapter *i2c;
i2c = of_find_i2c_adapter_by_node(panel->ddc_node);
--
2.4.6
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-08-12 8:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 8:46 [PATCH 1/4] gpmc: depend on MTD Lucas Stach
2015-08-12 8:46 ` [PATCH 2/4] video: MTL017: depend on I2C Lucas Stach
2015-08-19 14:11 ` Sascha Hauer
2015-08-12 8:46 ` Lucas Stach [this message]
2015-08-19 14:12 ` [PATCH 3/4] video: simple-panel: mode support depends on I2C and EDID Sascha Hauer
2015-08-12 8:46 ` [PATCH 4/4] video: backlight: add fallbacks for client functions Lucas Stach
2015-08-19 14:13 ` Sascha Hauer
2015-08-19 14:10 ` [PATCH 1/4] gpmc: depend on MTD Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439369205-26787-3-git-send-email-l.stach@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox