From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZYykA-0004Ds-1P for barebox@lists.infradead.org; Mon, 07 Sep 2015 15:54:07 +0000 Message-ID: <1441641223.28391.11.camel@pengutronix.de> From: Lucas Stach Date: Mon, 07 Sep 2015 17:53:43 +0200 In-Reply-To: <1441640663-25293-1-git-send-email-pmamonov@gmail.com> References: <20150903181352.GK18700@pengutronix.de> <1441640663-25293-1-git-send-email-pmamonov@gmail.com> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCHv2] ata: intf_platform_ide: add OF bindings To: Peter Mamonov Cc: barebox@lists.infradead.org Am Montag, den 07.09.2015, 18:44 +0300 schrieb Peter Mamonov: > Signed-off-by: Peter Mamonov > --- > drivers/ata/intf_platform_ide.c | 36 +++++++++++++++++++++++++++++++----- > 1 file changed, 31 insertions(+), 5 deletions(-) > > diff --git a/drivers/ata/intf_platform_ide.c b/drivers/ata/intf_platform_ide.c > index 0d392d8..e46c2c8 100644 > --- a/drivers/ata/intf_platform_ide.c > +++ b/drivers/ata/intf_platform_ide.c > @@ -29,6 +29,7 @@ > #include > #include > #include > +#include > > /** > * Setup the register specific addresses for an ATA like divice > @@ -85,8 +86,24 @@ static int platform_ide_probe(struct device_d *dev) > void *reg_base, *alt_base = NULL; > struct resource *reg, *alt; > int mmio = 0; > - > - if (pdata == NULL) { > + struct device_node *dn = dev->device_node; > + unsigned ioport_shift = 0; > + int dataif_be = 0; > + void (*reset)(int) = NULL; > + > + if (pdata) { > + ioport_shift = pdata->ioport_shift; > + dataif_be = pdata->dataif_be; > + reset = pdata->reset; > + } else if (dn) { > + /* try to get platform data from the device tree */ > + u32 tmp32; > + > + if (of_property_read_u32(dn, "reg-shift", &tmp32) == 0) > + ioport_shift = (unsigned)tmp32; This is okay, as it's already used by the established precedent in Linux. > + if (of_property_read_bool(dn, "dataif-be")) > + dataif_be = 1; This is not okay, there is no precedent for this property in Linux and there is no binding specifying this property. > + } else { > dev_err(dev, "No platform data. Cannot continue\n"); > return -EINVAL; > } > @@ -123,9 +140,9 @@ static int platform_ide_probe(struct device_d *dev) > ide = xzalloc(sizeof(*ide)); > ide->io.mmio = mmio; > > - platform_ide_setup_port(reg_base, alt_base, &ide->io, pdata->ioport_shift); > - ide->io.reset = pdata->reset; > - ide->io.dataif_be = pdata->dataif_be; > + platform_ide_setup_port(reg_base, alt_base, &ide->io, ioport_shift); > + ide->io.reset = reset; > + ide->io.dataif_be = dataif_be; > > rc = ide_port_register(ide); > if (rc != 0) { > @@ -136,9 +153,18 @@ static int platform_ide_probe(struct device_d *dev) > return rc; > } > > +static __maybe_unused struct of_device_id platform_ide_dt_ids[] = { > + { > + .compatible = "ata-generic", > + }, { > + /* sentinel */ > + } > +}; > + > static struct driver_d platform_ide_driver = { > .name = "ide_intf", > .probe = platform_ide_probe, > + .of_compatible = DRV_OF_COMPAT(platform_ide_dt_ids), > }; > device_platform_driver(platform_ide_driver); > -- Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox