From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH] of_fix_tree: Print error message
Date: Tue, 8 Sep 2015 15:50:30 +0200 [thread overview]
Message-ID: <1441720230-19670-1-git-send-email-s.hauer@pengutronix.de> (raw)
When a of_fixup handler fails add a meaningful error message so
that the user gets a clue what might have gone wrong.
Suggested-by: Enrico Joerns <ejo@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
common/oftree.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/common/oftree.c b/common/oftree.c
index f75d7b4..cafe46c 100644
--- a/common/oftree.c
+++ b/common/oftree.c
@@ -189,8 +189,11 @@ int of_fix_tree(struct device_node *node)
list_for_each_entry(of_fixup, &of_fixup_list, list) {
ret = of_fixup->fixup(node, of_fixup->context);
- if (ret)
+ if (ret) {
+ pr_err("Failed to fixup node in %pS: %s\n",
+ of_fixup->fixup, strerror(-ret));
return ret;
+ }
}
return 0;
--
2.5.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
reply other threads:[~2015-09-08 13:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441720230-19670-1-git-send-email-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox