mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] of_fix_tree: Print error message
@ 2015-09-08 13:50 Sascha Hauer
  0 siblings, 0 replies; only message in thread
From: Sascha Hauer @ 2015-09-08 13:50 UTC (permalink / raw)
  To: Barebox List

When a of_fixup handler fails add a meaningful error message so
that the user gets a clue what might have gone wrong.

Suggested-by: Enrico Joerns <ejo@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 common/oftree.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/common/oftree.c b/common/oftree.c
index f75d7b4..cafe46c 100644
--- a/common/oftree.c
+++ b/common/oftree.c
@@ -189,8 +189,11 @@ int of_fix_tree(struct device_node *node)
 
 	list_for_each_entry(of_fixup, &of_fixup_list, list) {
 		ret = of_fixup->fixup(node, of_fixup->context);
-		if (ret)
+		if (ret) {
+			pr_err("Failed to fixup node in %pS: %s\n",
+					of_fixup->fixup, strerror(-ret));
 			return ret;
+		}
 	}
 
 	return 0;
-- 
2.5.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-09-08 13:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-08 13:50 [PATCH] of_fix_tree: Print error message Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox