From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 2/2] fixup! input: port usb keyboard driver from the u-boot
Date: Wed, 23 Sep 2015 16:34:55 +0200 [thread overview]
Message-ID: <1443018895-20796-2-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1443018895-20796-1-git-send-email-s.hauer@pengutronix.de>
No need for coherent memory in the keyboard driver. The USB driver should
handle the cache handling.
---
drivers/input/usb_kbd.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/input/usb_kbd.c b/drivers/input/usb_kbd.c
index 3d70c8d..8c08aba 100644
--- a/drivers/input/usb_kbd.c
+++ b/drivers/input/usb_kbd.c
@@ -347,7 +347,7 @@ static int usb_kbd_probe(struct usb_device *usbdev,
data = xzalloc(sizeof(struct usb_kbd_pdata));
usbdev->drv_data = data;
data->recv_fifo = kfifo_alloc(USB_KBD_FIFO_SIZE);
- data->new = dma_alloc_coherent(USB_KBD_BOOT_REPORT_SIZE, NULL);
+ data->new = dma_alloc(USB_KBD_BOOT_REPORT_SIZE);
data->usbdev = usbdev;
data->last_report = get_time_ns();
@@ -369,8 +369,7 @@ static int usb_kbd_probe(struct usb_device *usbdev,
if (ret < 0) {
/* no luck */
kfifo_free(data->recv_fifo);
- dma_free_coherent(data->new, 0,
- USB_KBD_BOOT_REPORT_SIZE);
+ dma_free(data->new);
free(data);
return ret;
} else
@@ -398,7 +397,7 @@ static void usb_kbd_disconnect(struct usb_device *usbdev)
poller_unregister(&data->poller);
console_unregister(&data->cdev);
kfifo_free(data->recv_fifo);
- dma_free_coherent(data->new, 0, USB_KBD_BOOT_REPORT_SIZE);
+ dma_free(data->new);
free(data);
}
--
2.5.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2015-09-23 14:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 15:58 [PATCH v6 0/5] input: add usb keyboard driver Peter Mamonov
2015-09-22 15:58 ` [PATCH 1/5] common: clock: introduce mdelay_non_interruptible() Peter Mamonov
2015-09-22 21:15 ` Antony Pavlov
2015-09-22 21:20 ` Peter Mamonov
2015-09-22 15:58 ` [PATCH 2/5] usb: ehci-hcd: port periodic transactions implementation from the u-boot Peter Mamonov
2015-09-22 15:58 ` [PATCH 3/5] usb: ehci-hcd: detect re-entrance Peter Mamonov
2015-09-23 14:23 ` Sascha Hauer
2015-09-22 15:58 ` [PATCH 4/5] usb: ehci-hcd: use mdelay_non_inerruptible() Peter Mamonov
2015-10-07 13:47 ` Jean-Christophe PLAGNIOL-VILLARD
2015-10-07 14:40 ` Peter Mamonov
2015-10-07 15:40 ` Jean-Christophe PLAGNIOL-VILLARD
2015-10-07 16:52 ` Peter Mamonov
2015-10-12 7:00 ` Sascha Hauer
2015-10-12 11:43 ` Peter Mamonov
2015-10-12 13:44 ` Sascha Hauer
2015-10-13 10:37 ` Peter Mamonov
2015-10-13 10:38 ` Sascha Hauer
2015-10-13 2:04 ` Jean-Christophe PLAGNIOL-VILLARD
2015-10-13 9:11 ` Antony Pavlov
2015-09-22 15:58 ` [PATCH 5/5] input: port usb keyboard driver from the u-boot Peter Mamonov
2015-09-23 14:34 ` [PATCH 1/2] fixup! usb: ehci-hcd: port periodic transactions implementation " Sascha Hauer
2015-09-23 14:34 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443018895-20796-2-git-send-email-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox