[PATCH] imx6-mmdc: restore RALAT/WALAT in MMDC0, not MMDC1

[PATCH] imx6-mmdc: restore RALAT/WALAT in MMDC0, not MMDC1

[Eric Nelson]

Signed-off-by: Eric Nelson <eric@nelint.com>
---
 arch/arm/mach-imx/imx6-mmdc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-imx/imx6-mmdc.c b/arch/arm/mach-imx/imx6-mmdc.c
index 40fe0cf..7840c1a 100644
--- a/arch/arm/mach-imx/imx6-mmdc.c
+++ b/arch/arm/mach-imx/imx6-mmdc.c
@@ -474,7 +474,7 @@ int mmdc_do_dqs_calibration(void)
 	writel(v, P0_IPS + MAPSR);
 
 	/* restore MDMISC value (RALAT, WALAT) */
-	writel(esdmisc_val, P1_IPS + MDMISC);
+	writel(esdmisc_val, P0_IPS + MDMISC);
 
 	/* clear DQS pull ups */
 	v = readl(IOMUXC_SW_PAD_CTL_PAD_DRAM_SDQS0) & ~0x7000;
-- 
2.6.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] imx6-mmdc: restore RALAT/WALAT in MMDC0, not MMDC1

[Sascha Hauer]

On Fri, Oct 23, 2015 at 04:34:40PM -0700, Eric Nelson wrote:
> Signed-off-by: Eric Nelson <eric@nelint.com>
> ---
>  arch/arm/mach-imx/imx6-mmdc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/arch/arm/mach-imx/imx6-mmdc.c b/arch/arm/mach-imx/imx6-mmdc.c
> index 40fe0cf..7840c1a 100644
> --- a/arch/arm/mach-imx/imx6-mmdc.c
> +++ b/arch/arm/mach-imx/imx6-mmdc.c
> @@ -474,7 +474,7 @@ int mmdc_do_dqs_calibration(void)
>  	writel(v, P0_IPS + MAPSR);
>  
>  	/* restore MDMISC value (RALAT, WALAT) */
> -	writel(esdmisc_val, P1_IPS + MDMISC);
> +	writel(esdmisc_val, P0_IPS + MDMISC);
>  
>  	/* clear DQS pull ups */
>  	v = readl(IOMUXC_SW_PAD_CTL_PAD_DRAM_SDQS0) & ~0x7000;
> -- 
> 2.6.2
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] imx6-mmdc: restore RALAT/WALAT in MMDC0, not MMDC1

[Eric Nelson]

Hi Sascha,

On 10/25/2015 11:54 PM, Sascha Hauer wrote:
> On Fri, Oct 23, 2015 at 04:34:40PM -0700, Eric Nelson wrote:
>> Signed-off-by: Eric Nelson <eric@nelint.com>
>> ---
>>  arch/arm/mach-imx/imx6-mmdc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied, thanks
> 
> Sascha
> 
>>
>> diff --git a/arch/arm/mach-imx/imx6-mmdc.c b/arch/arm/mach-imx/imx6-mmdc.c
>> index 40fe0cf..7840c1a 100644
>> --- a/arch/arm/mach-imx/imx6-mmdc.c
>> +++ b/arch/arm/mach-imx/imx6-mmdc.c
>> @@ -474,7 +474,7 @@ int mmdc_do_dqs_calibration(void)
>>  	writel(v, P0_IPS + MAPSR);
>>  
>>  	/* restore MDMISC value (RALAT, WALAT) */
>> -	writel(esdmisc_val, P1_IPS + MDMISC);
>> +	writel(esdmisc_val, P0_IPS + MDMISC);
>>  
>>  	/* clear DQS pull ups */
>>  	v = readl(IOMUXC_SW_PAD_CTL_PAD_DRAM_SDQS0) & ~0x7000;
>> -- 
>> 2.6.2
>>
>>
> 

Note that this typo should have had an impact on performance
because RALAT and WALAT for MMDC0 would be left at their
max values.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox