mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Trent Piepho <tpiepho@kymetacorp.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>,
	Peter Mamonov <pmamonov@gmail.com>
Subject: Re: [PATCH] common: filetype: do not redetect MBR-type devices as a FAT-type
Date: Tue, 10 Nov 2015 18:44:38 +0000	[thread overview]
Message-ID: <1447181079.4553.82.camel@rtred1test09.kymeta.local> (raw)
In-Reply-To: <20151110080423.GE8526@pengutronix.de>

On Tue, 2015-11-10 at 09:04 +0100, Sascha Hauer wrote:

> From 98fb34f2aa271138eab28a36aec733fe6572339c Mon Sep 17 00:00:00 2001
> From: Sascha Hauer <s.hauer@pengutronix.de>
> Date: Tue, 10 Nov 2015 08:58:16 +0100
> Subject: [PATCH] ARM: omap: Use correct device to mount on /boot
> 
> The current code tests if a partition (i.e. disk0.0) exists and instead
> of mounting boot from this partition it uses the whole device (disk0).
> This only works because the the FAT code accepts a MBR as input and
> automatically skips it.

I agree, this should fix it.

> 
> Let the code use the partition to mount /boot instead as it was
> intended. We don't have to stat() the partition device, since this
> error will be caught by mount() anyway, so remove the unnecessary
> stat().

There are copies of this code in rpi.c and socfpga/generic.c.  They
don't suffer from the whole disk flaw, but they do stat() first as well.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2015-11-10 18:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-09 10:32 Peter Mamonov
2015-11-09 11:18 ` Antony Pavlov
2015-11-09 18:49 ` Trent Piepho
2015-11-10  8:04   ` Sascha Hauer
2015-11-10  8:15     ` Sascha Hauer
2015-11-10 18:44     ` Trent Piepho [this message]
2015-11-11  7:35 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447181079.4553.82.camel@rtred1test09.kymeta.local \
    --to=tpiepho@kymetacorp.com \
    --cc=barebox@lists.infradead.org \
    --cc=pmamonov@gmail.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox