mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Lucas Stach <dev@lynxeye.de>
To: barebox@lists.infradead.org
Subject: [PATCH] video: imx: quieten down VPL output
Date: Wed, 11 Nov 2015 20:55:54 +0100	[thread overview]
Message-ID: <1447271754-13692-1-git-send-email-dev@lynxeye.de> (raw)

Printing 3 lines of output per CRTC if no modes are found (which
may be just fine if no display is attached) is just a bit too much,
especially on SoCs like i.MX6Q that carry 4 CRTCs.
Failing to find modes is not a fatal error, so the error does not
need to be propagated into a probe failure.

Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
 drivers/video/imx-ipu-v3/ipufb.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/video/imx-ipu-v3/ipufb.c b/drivers/video/imx-ipu-v3/ipufb.c
index a96883c..ea81270 100644
--- a/drivers/video/imx-ipu-v3/ipufb.c
+++ b/drivers/video/imx-ipu-v3/ipufb.c
@@ -308,7 +308,7 @@ static int ipufb_probe(struct device_d *dev)
 
 	node = of_graph_get_port_by_id(dev->parent->device_node, 2 + pdata->di);
 	if (node && of_graph_port_is_available(node)) {
-		dev_info(fbi->dev, "register vpl for %s\n", dev->parent->device_node->full_name);
+		dev_dbg(fbi->dev, "register vpl for %s\n", dev->parent->device_node->full_name);
 
 		fbi->vpl.node = dev->parent->device_node;
 		ret = vpl_register(&fbi->vpl);
@@ -330,8 +330,8 @@ static int ipufb_probe(struct device_d *dev)
 
 		ret = vpl_ioctl(&fbi->vpl, 2 + fbi->dino, VPL_GET_VIDEOMODES, &info->modes);
 		if (ret) {
-			dev_err(fbi->dev, "failed to get modes: %s\n", strerror(-ret));
-			return ret;
+			dev_dbg(fbi->dev, "failed to get modes: %s\n", strerror(-ret));
+			return 0;
 		}
 
 		ret = register_framebuffer(info);
-- 
2.5.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2015-11-11 19:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-11 19:55 Lucas Stach [this message]
2015-11-13  7:34 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447271754-13692-1-git-send-email-dev@lynxeye.de \
    --to=dev@lynxeye.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox