* [PATCH] graphics_utils: check for valid framebuffer before creating a screen
@ 2015-11-13 7:37 Sascha Hauer
0 siblings, 0 replies; only message in thread
From: Sascha Hauer @ 2015-11-13 7:37 UTC (permalink / raw)
To: Barebox List
Otherwise we crash later when we try to print on that screen.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
lib/gui/graphic_utils.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/gui/graphic_utils.c b/lib/gui/graphic_utils.c
index 4c1885d..2fe9fa3 100644
--- a/lib/gui/graphic_utils.c
+++ b/lib/gui/graphic_utils.c
@@ -249,6 +249,10 @@ struct screen *fb_create_screen(struct fb_info *info)
{
struct screen *sc;
+ if (!info->xres || !info->yres || !info->line_length ||
+ !info->screen_base)
+ return ERR_PTR(-EINVAL);
+
sc = xzalloc(sizeof(*sc));
sc->s.x = 0;
--
2.6.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-11-13 7:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-13 7:37 [PATCH] graphics_utils: check for valid framebuffer before creating a screen Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox