[PATCH 3/3] Makefile: set -Wmissing-prototypes on all architechtures (was only on mips)

[PATCH 3/3] Makefile: set -Wmissing-prototypes on all architechtures (was only on mips)

[Sergey Koshechkin]

Signed-off-by: Sergey Koshechkin <serge.koshechkin@gmail.com>
---
 Makefile           | 2 +-
 arch/mips/Makefile | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 1029dc1..9a54a44 100644
--- a/Makefile
+++ b/Makefile
@@ -183,7 +183,7 @@ CONFIG_SHELL := $(shell if [ -x "$$BASH" ]; then echo $$BASH; \
 
 HOSTCC       = gcc
 HOSTCXX      = g++
-HOSTCFLAGS   = -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer
+HOSTCFLAGS   = -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer
 HOSTCXXFLAGS = -O2
 
 # Decide whether to build built-in, modular, or both.
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index 75761b5..b003945 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -12,7 +12,7 @@ endif
 CPPFLAGS += -D__MIPS__ -fno-strict-aliasing -fno-merge-constants
 
 cflags-y += -G 0 -mno-abicalls -fno-pic -pipe
-cflags-y += -Wall -Wmissing-prototypes -Wstrict-prototypes \
+cflags-y += -Wall -Wstrict-prototypes \
 	-Wno-uninitialized -Wno-format -Wno-main
 
 ifdef CONFIG_32BIT
-- 
2.6.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 3/3] Makefile: set -Wmissing-prototypes on all architechtures (was only on mips)

[Lucas Stach]

Am Dienstag, den 17.11.2015, 15:15 +0300 schrieb Sergey Koshechkin:
> Signed-off-by: Sergey Koshechkin <serge.koshechkin@gmail.com>
> ---
>  Makefile           | 2 +-
>  arch/mips/Makefile | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 1029dc1..9a54a44 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -183,7 +183,7 @@ CONFIG_SHELL := $(shell if [ -x "$$BASH" ]; then echo $$BASH; \
>  
>  HOSTCC       = gcc
>  HOSTCXX      = g++
> -HOSTCFLAGS   = -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer
> +HOSTCFLAGS   = -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer
>  HOSTCXXFLAGS = -O2
>  
>  # Decide whether to build built-in, modular, or both.
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index 75761b5..b003945 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -12,7 +12,7 @@ endif
>  CPPFLAGS += -D__MIPS__ -fno-strict-aliasing -fno-merge-constants
>  
>  cflags-y += -G 0 -mno-abicalls -fno-pic -pipe
> -cflags-y += -Wall -Wmissing-prototypes -Wstrict-prototypes \
> +cflags-y += -Wall -Wstrict-prototypes \

Wstrict-prototypes is already set for all architectures, as seen above.
Can you remove it here?

>  	-Wno-uninitialized -Wno-format -Wno-main
>  
>  ifdef CONFIG_32BIT

-- 
Pengutronix e.K.             | Lucas Stach                 |
Industrial Linux Solutions   | http://www.pengutronix.de/  |


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 3/3] Makefile: set -Wmissing-prototypes on all architechtures (was only on mips)

[Sascha Hauer]

On Tue, Nov 17, 2015 at 03:15:22PM +0300, Sergey Koshechkin wrote:
> Signed-off-by: Sergey Koshechkin <serge.koshechkin@gmail.com>
> ---
>  Makefile           | 2 +-
>  arch/mips/Makefile | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 1029dc1..9a54a44 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -183,7 +183,7 @@ CONFIG_SHELL := $(shell if [ -x "$$BASH" ]; then echo $$BASH; \
>  
>  HOSTCC       = gcc
>  HOSTCXX      = g++
> -HOSTCFLAGS   = -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer
> +HOSTCFLAGS   = -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer
>  HOSTCXXFLAGS = -O2
>  
>  # Decide whether to build built-in, modular, or both.
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index 75761b5..b003945 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -12,7 +12,7 @@ endif
>  CPPFLAGS += -D__MIPS__ -fno-strict-aliasing -fno-merge-constants
>  
>  cflags-y += -G 0 -mno-abicalls -fno-pic -pipe
> -cflags-y += -Wall -Wmissing-prototypes -Wstrict-prototypes \

You are removing this from cflags, but adding to HOSTCFLAGS above, these
variables are not equivalent. You should add to CFLAGS instead. Now I
know why I haven't seen these warnings from the host tools before.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox