mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: Sergey Koshechkin <serge.koshechkin@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/3] Makefile: set -Wmissing-prototypes on all architechtures (was only on mips)
Date: Tue, 17 Nov 2015 16:09:24 +0100	[thread overview]
Message-ID: <1447772964.3144.50.camel@pengutronix.de> (raw)
In-Reply-To: <1447762522-13533-1-git-send-email-serge.koshechkin@gmail.com>

Am Dienstag, den 17.11.2015, 15:15 +0300 schrieb Sergey Koshechkin:
> Signed-off-by: Sergey Koshechkin <serge.koshechkin@gmail.com>
> ---
>  Makefile           | 2 +-
>  arch/mips/Makefile | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 1029dc1..9a54a44 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -183,7 +183,7 @@ CONFIG_SHELL := $(shell if [ -x "$$BASH" ]; then echo $$BASH; \
>  
>  HOSTCC       = gcc
>  HOSTCXX      = g++
> -HOSTCFLAGS   = -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer
> +HOSTCFLAGS   = -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer
>  HOSTCXXFLAGS = -O2
>  
>  # Decide whether to build built-in, modular, or both.
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index 75761b5..b003945 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -12,7 +12,7 @@ endif
>  CPPFLAGS += -D__MIPS__ -fno-strict-aliasing -fno-merge-constants
>  
>  cflags-y += -G 0 -mno-abicalls -fno-pic -pipe
> -cflags-y += -Wall -Wmissing-prototypes -Wstrict-prototypes \
> +cflags-y += -Wall -Wstrict-prototypes \

Wstrict-prototypes is already set for all architectures, as seen above.
Can you remove it here?

>  	-Wno-uninitialized -Wno-format -Wno-main
>  
>  ifdef CONFIG_32BIT

-- 
Pengutronix e.K.             | Lucas Stach                 |
Industrial Linux Solutions   | http://www.pengutronix.de/  |


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2015-11-17 15:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-17 12:15 Sergey Koshechkin
2015-11-17 15:09 ` Lucas Stach [this message]
2015-11-18  7:45 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447772964.3144.50.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=serge.koshechkin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox