mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jason Cobham <cobham.jason@gmail.com>
To: barebox@lists.infradead.org
Cc: cobham.jason@gmail.com
Subject: [PATCH 4/4] ARM: ccxmx53: Formatting changes and remove un-used code.
Date: Tue, 17 Nov 2015 20:27:04 -0800	[thread overview]
Message-ID: <1447820824-12471-4-git-send-email-cobham.jason@gmail.com> (raw)
In-Reply-To: <1447820824-12471-1-git-send-email-cobham.jason@gmail.com>

Tested with a 512M and 1GB module on a JSK dev board.
Signed-off-by: Jason Cobham <cobham.jason@gmail.com>
---
 arch/arm/boards/ccxmx53/board.c | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/arch/arm/boards/ccxmx53/board.c b/arch/arm/boards/ccxmx53/board.c
index 721eb0d..a6d37e2 100644
--- a/arch/arm/boards/ccxmx53/board.c
+++ b/arch/arm/boards/ccxmx53/board.c
@@ -70,12 +70,9 @@ static void ccwmx53_fec_reset(void)
 	gpio_set_value(ccwmx53_FEC_PHY_RST, 1);
 }
 
-/*
- * Configure this board for 256Mb. The real
- * size is determined by the board id read from the IIM module
- * and added as ram1.
- */
-
+/* On these boards, memory information is encoded in the MAC address.
+ * Print device memory, and option info from lookup table.
+ * */
 static int ccwmx53_devices_init(void)
 {
 	u8 hwid[6] = {0};
@@ -108,10 +105,7 @@ static int ccwmx53_devices_init(void)
 		}
 		printf("Module Serial : %c%d\n", manloc, ((hwid[2] & 0x3f) << 24) | (hwid[3] << 16) | (hwid[4] << 8) | hwid[5]);
 		printf("Module RAM    : %dK\n", (ccwmx53_id->mem_sz)/1024);
-		if ((ccwmx53_id->mem_sz - SZ_512M) > 0)
-		{
-			//arm_add_mem_device("ram1", MX53_CSD0_BASE_ADDR + SZ_512M, (ccwmx53_id->mem_sz)-SZ_512M);
-		}
+
 	} else {
 		return -ENOSYS;
 	}
@@ -146,7 +140,7 @@ static int ccxmx53_reg_init(void)
 	client.adapter = adapter;
 	client.addr = addr;
 
-	/* Enable 3.3V ext regulator. This is not supported in dt */
+	/* Enable 3.3V ext regulator. */
 	value = 0xfa;
 	if (i2c_write_reg(&client, 0x19, &value, 1) < 0){
 		printf("****I2C write failed\n");
-- 
1.9.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2015-11-18  4:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-18  4:27 [PATCH 1/4] ARM: ccxmx53: Add support for Digi ccxmx53 board Jason Cobham
2015-11-18  4:27 ` [PATCH 2/4] ARM: ccxmx53: Added memory detection Jason Cobham
2015-11-18  4:27 ` [PATCH 3/4] ARM: ccxmx53: Add 512MB and 1GB boards Jason Cobham
2015-11-18  4:27 ` Jason Cobham [this message]
2015-11-18  7:33   ` [PATCH 4/4] ARM: ccxmx53: Formatting changes and remove un-used code Uwe Kleine-König
2015-11-18  7:57 ` [PATCH 1/4] ARM: ccxmx53: Add support for Digi ccxmx53 board Sascha Hauer
2015-11-18 17:56 ` Trent Piepho
2015-11-20  3:42   ` Jason Cobham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447820824-12471-4-git-send-email-cobham.jason@gmail.com \
    --to=cobham.jason@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox