[PATCH] state: make type check error verbose

[PATCH] state: make type check error verbose

[Jan Remmet]

Wrong type let state probe fail with ENOENT.

Signed-off-by: Jan Remmet <j.remmet@phytec.de>
---
 common/state.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/common/state.c b/common/state.c
index 117a686..a161b94 100644
--- a/common/state.c
+++ b/common/state.c
@@ -716,6 +716,8 @@ static int state_convert_node_variable(struct state *state,
 
 	vtype = state_find_type_by_name(type_name);
 	if (!vtype) {
+		dev_err(&state->dev, "unkown type: %s in %s\n", type_name,
+			node->full_name);
 		ret = -ENOENT;
 		goto out_free;
 	}
-- 
1.9.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] state: make type check error verbose

[Sascha Hauer]

On Fri, Nov 20, 2015 at 10:03:18AM +0100, Jan Remmet wrote:
> Wrong type let state probe fail with ENOENT.
> 
> Signed-off-by: Jan Remmet <j.remmet@phytec.de>
> ---
>  common/state.c | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/common/state.c b/common/state.c
> index 117a686..a161b94 100644
> --- a/common/state.c
> +++ b/common/state.c
> @@ -716,6 +716,8 @@ static int state_convert_node_variable(struct state *state,
>  
>  	vtype = state_find_type_by_name(type_name);
>  	if (!vtype) {
> +		dev_err(&state->dev, "unkown type: %s in %s\n", type_name,
> +			node->full_name);
>  		ret = -ENOENT;
>  		goto out_free;
>  	}
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox