mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	barebox@lists.infradead.org
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Subject: [PATCH v2 10/19] mtd: nand_mrvl_nfc: Fix num-cs property parsing
Date: Fri, 20 Nov 2015 20:36:03 +0100	[thread overview]
Message-ID: <1448048172-10080-11-git-send-email-sebastian.hesselbarth@gmail.com> (raw)
In-Reply-To: <1448048172-10080-1-git-send-email-sebastian.hesselbarth@gmail.com>

The "num-cs" property does not encode flashes CS line but number
of available CS signals. Fix wrong property parsing to ->cs by
adding proper ->num_cs variable to host struct.

Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Tested-by: Robert Jarzmik <robert.jarzmik@free.fr>
---
 drivers/mtd/nand/nand_mrvl_nfc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/nand_mrvl_nfc.c b/drivers/mtd/nand/nand_mrvl_nfc.c
index 95abd4ddf243..5374e64965a2 100644
--- a/drivers/mtd/nand/nand_mrvl_nfc.c
+++ b/drivers/mtd/nand/nand_mrvl_nfc.c
@@ -153,6 +153,7 @@ struct mrvl_nand_host {
 	int			ecc_strength;
 	int			ecc_step;
 
+	int			num_cs;		/* avaiable CS signals */
 	int			cs;		/* selected chip 0/1 */
 	int			use_ecc;	/* use HW ECC ? */
 	int			use_spare;	/* use spare ? */
@@ -929,6 +930,7 @@ static struct mrvl_nand_host *alloc_nand_resource(struct device_d *dev)
 
 	pdata = dev->platform_data;
 	host = xzalloc(sizeof(*host));
+	host->num_cs = 1;
 	host->cs = 0;
 	mtd = &host->mtd;
 	mtd->priv = &host->chip;
@@ -988,7 +990,7 @@ static int mrvl_nand_probe_dt(struct mrvl_nand_host *host)
 
 	if (of_get_property(np, "marvell,nand-keep-config", NULL))
 		host->keep_config = 1;
-	of_property_read_u32(np, "num-cs", &host->cs);
+	of_property_read_u32(np, "num-cs", &host->num_cs);
 	if (of_get_nand_on_flash_bbt(np))
 		host->flash_bbt = 1;
 
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2015-11-19 20:33 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20 19:35 [PATCH v2 00/19] Armada 370/XP NAND driver Sebastian Hesselbarth
2015-11-20 19:35 ` [PATCH v2 01/19] of: mtd: Import of_get_nand_ecc_{step_size, strength} from Linux Sebastian Hesselbarth
2015-11-20 19:35 ` [PATCH v2 02/19] mtd: nand: Clarify Marvell Orion Kconfig prompt Sebastian Hesselbarth
2015-11-20 19:35 ` [PATCH v2 03/19] arm: pxa: Prepare for NAND clkdev lookup on PXA3xx Sebastian Hesselbarth
2015-11-20 19:35 ` [PATCH v2 04/19] arm: pxa: Add clock for Zylonite NFC Sebastian Hesselbarth
2015-11-20 19:35 ` [PATCH v2 05/19] mtd: nand_mrvl_nfc: Use common clock for core clock Sebastian Hesselbarth
2015-11-20 19:35 ` [PATCH v2 06/19] arm: pxa: Remove pxa_get_nandclk() Sebastian Hesselbarth
2015-11-20 19:36 ` [PATCH v2 07/19] mtd: nand_mrvl_nfc: Clear OOB data with 0xff instead of 0x00 Sebastian Hesselbarth
2015-11-20 19:36 ` [PATCH v2 08/19] mtd: nand_mrvl_nfc: Use Auto Read Status on program/erase Sebastian Hesselbarth
2015-11-20 19:36 ` [PATCH v2 09/19] mtd: nand_mrvl_nfc: Protect mrvl_nand_probe_dt Sebastian Hesselbarth
2015-11-20 19:36 ` Sebastian Hesselbarth [this message]
2015-11-20 19:36 ` [PATCH v2 11/19] mtd: nand_mrvl_nfc: Get ecc parameters from DT Sebastian Hesselbarth
2015-11-20 19:36 ` [PATCH v2 12/19] mtd: nand_mrvl_nfc: Prepare for different HW ECC strengths Sebastian Hesselbarth
2015-11-20 20:38   ` Trent Piepho
2015-11-23  7:18     ` Sascha Hauer
2015-11-20 19:36 ` [PATCH v2 13/19] mtd: nand_mrvl_nfc: Add hwflags to distinguish different HW versions Sebastian Hesselbarth
2015-11-20 19:36 ` [PATCH v2 14/19] mtd: nand_mrvl_nfc: Add support for 4bit BCH HW ECC Sebastian Hesselbarth
2015-11-20 19:36 ` [PATCH v2 15/19] mtd: nand_mrvl_nfc: Add support for 8bit " Sebastian Hesselbarth
2015-11-20 19:36 ` [PATCH v2 16/19] mtd: nand_mrvl_nfc: Add support for HW BCH ECC Sebastian Hesselbarth
2015-11-20 19:36 ` [PATCH v2 17/19] mtd: nand_mrvl_nfc: Add support for NDCB3 register Sebastian Hesselbarth
2015-11-20 19:36 ` [PATCH v2 18/19] mtd: nand_mrvl_nfc: Add support for Marvell Armada 370/XP Sebastian Hesselbarth
2015-11-20 19:36 ` [PATCH v2 19/19] mtd: nand_mrvl_nfc: Add optimized timings for Samsung K9K8G08U Sebastian Hesselbarth
2015-11-23  7:19 ` [PATCH v2 00/19] Armada 370/XP NAND driver Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448048172-10080-11-git-send-email-sebastian.hesselbarth@gmail.com \
    --to=sebastian.hesselbarth@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=ezequiel@vanguardiasur.com.ar \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox