From: Trent Piepho <tpiepho@kymetacorp.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox <barebox@lists.infradead.org>
Subject: Re: [PATCH] ARM: Remove kernel booting call for thumb2 mode
Date: Fri, 4 Dec 2015 19:19:41 +0000 [thread overview]
Message-ID: <1449256786.26955.19.camel@rtred1test09.kymeta.local> (raw)
In-Reply-To: <20151204073048.GV11966@pengutronix.de>
On Fri, 2015-12-04 at 08:30 +0100, Sascha Hauer wrote:
> On Fri, Dec 04, 2015 at 02:28:40AM +0000, Trent Piepho wrote:
> >
> > This doesn't seem necessary for the same reason as the code in
> > start_linux. THUMB2 selects AEABI, which in turn turns on the aapcs
> > abi, which requires interworking safe indirect calls. And again, the
> > bootstrap code doesn't use a special call sequence so if it didn't work
> > that would be broken too.
> >
>
> This is a bug. We want to shift argv[] by one, not by two. I must
> accidently have done this twice.
> As you note the thumb2 execution code is unnecessary anyway, we can
> remove the bug by removing the code.
Ok, I'll send a patch for it. I thought maybe there was some sort of
gcc bug or deficiency back in 2011 that made this necessary. Though I
did search for bug with thumb interworking or "mov pc, reg" and didn't
find any that looked like they would be relevant.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-12-04 19:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 1:24 Trent Piepho
2015-12-04 2:28 ` Trent Piepho
2015-12-04 7:30 ` Sascha Hauer
2015-12-04 19:19 ` Trent Piepho [this message]
2015-12-04 7:20 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449256786.26955.19.camel@rtred1test09.kymeta.local \
--to=tpiepho@kymetacorp.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox