mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: barebox@lists.infradead.org
Subject: [PATCH] ARM: pxa: pxa2xx use PSPR for resume address
Date: Sat,  5 Dec 2015 23:37:05 +0100	[thread overview]
Message-ID: <1449355025-20972-1-git-send-email-robert.jarzmik@free.fr> (raw)

Both lubbock and mainstone suspend to RAM were broken by the same
typo. The linux kernel saves the resume address to PSPR, ie. the scratch
pad register, while it was PSSR which was checked in barebox.

Fixing this typo was tested on mainstone where resume from S3 works.

Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
---
 arch/arm/boards/lubbock/lowlevel.c   | 2 +-
 arch/arm/boards/mainstone/lowlevel.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boards/lubbock/lowlevel.c b/arch/arm/boards/lubbock/lowlevel.c
index 3c8ae76..1c52b3e 100644
--- a/arch/arm/boards/lubbock/lowlevel.c
+++ b/arch/arm/boards/lubbock/lowlevel.c
@@ -171,7 +171,7 @@ static inline void pxa2xx_dram_init(void)
 
 void __bare_init __naked barebox_arm_reset_vector(void)
 {
-	unsigned long pssr = PSSR;
+	unsigned long pssr = PSPR;
 	unsigned long pc = get_pc();
 
 	arm_cpu_lowlevel_init();
diff --git a/arch/arm/boards/mainstone/lowlevel.c b/arch/arm/boards/mainstone/lowlevel.c
index 86bb09c..8983941 100644
--- a/arch/arm/boards/mainstone/lowlevel.c
+++ b/arch/arm/boards/mainstone/lowlevel.c
@@ -243,7 +243,7 @@ static inline void pxa2xx_dram_init(void)
 
 void __bare_init __naked barebox_arm_reset_vector(void)
 {
-	unsigned long pssr = PSSR;
+	unsigned long pssr = PSPR;
 	unsigned long pc = get_pc();
 
 	arm_cpu_lowlevel_init();
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2015-12-05 22:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-05 22:37 Robert Jarzmik [this message]
2015-12-07  9:48 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449355025-20972-1-git-send-email-robert.jarzmik@free.fr \
    --to=robert.jarzmik@free.fr \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox