mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* Messed up commit in master
@ 2015-12-08 15:58 Lucas Stach
  2015-12-10  7:54 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Lucas Stach @ 2015-12-08 15:58 UTC (permalink / raw)
  To: barebox

Hi Sascha,

I've just stumbled across a messed up commit that landed in barebox
master. It seems you squashed other unrelated commits into commit
e7a8519963fcb235a123dfe5e7dd59d6fb2eaf9e (ARM: mx6sx-sabresdb: set
proper hostname).

I know its against the master stability rules, but I think it would be
justified to split this commit properly and re-push a fixed master.

Regards,
Lucas
-- 
Pengutronix e.K.             | Lucas Stach                 |
Industrial Linux Solutions   | http://www.pengutronix.de/  |


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Messed up commit in master
  2015-12-08 15:58 Messed up commit in master Lucas Stach
@ 2015-12-10  7:54 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2015-12-10  7:54 UTC (permalink / raw)
  To: Lucas Stach; +Cc: barebox

On Tue, Dec 08, 2015 at 04:58:22PM +0100, Lucas Stach wrote:
> Hi Sascha,
> 
> I've just stumbled across a messed up commit that landed in barebox
> master. It seems you squashed other unrelated commits into commit
> e7a8519963fcb235a123dfe5e7dd59d6fb2eaf9e (ARM: mx6sx-sabresdb: set
> proper hostname).
> 
> I know its against the master stability rules, but I think it would be
> justified to split this commit properly and re-push a fixed master.

I messed it up, but unfortunately we have to live with it. I won't
rebase master. In the end nothing bad has happened, only that one commit
has the wrong commit message.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-12-10  7:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-08 15:58 Messed up commit in master Lucas Stach
2015-12-10  7:54 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox