mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH 6/7] miitool: Don't print negative parent IDs
Date: Mon, 25 Jan 2016 21:55:57 -0800	[thread overview]
Message-ID: <1453787758-12688-6-git-send-email-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <1453787758-12688-1-git-send-email-andrew.smirnov@gmail.com>

Do not include ID of the parent to mii_bus if that ID is negative since
it produces a rather confusing string (e.g. "mdio.11-1", which is very
likely to be interpreted as "mdio.11<dash>1").

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 commands/miitool.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/commands/miitool.c b/commands/miitool.c
index 9ee3597..9ea5ab5 100644
--- a/commands/miitool.c
+++ b/commands/miitool.c
@@ -115,8 +115,9 @@ static int show_basic_mii(struct mii_bus *mii, struct phy_device *phydev,
 	for (i = 0; i < 32; i++)
 		mii_val[i] = mii->read(mii, phydev->addr, i);
 
-	printf("%s: %s%d: ", phydev->cdev.name,
-		mii->parent->name, mii->parent->id);
+	printf((mii->parent->id) < 0 ? "%s: %s:" : "%s: %s%d: ",
+	       phydev->cdev.name, mii->parent->name, mii->parent->id);
+
 
 	if (mii_val[MII_BMCR] == 0xffff || mii_val[MII_BMSR] == 0x0000) {
 		fprintf(stderr, "  No MII transceiver present!.\n");
-- 
2.5.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2016-01-26  5:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-26  5:55 [PATCH 1/7] include/linux/phy.h: Add MII_ADDR_C45 Andrey Smirnov
2016-01-26  5:55 ` [PATCH 2/7] net: Port bitbanged MDIO code from Linux kernel Andrey Smirnov
2016-01-26  5:55 ` [PATCH 3/7] miitool: Fix PHY argument handling Andrey Smirnov
2016-01-26  5:55 ` [PATCH 4/7] mdio_bus: Change dev_info to dev_dbg Andrey Smirnov
2016-01-26  5:55 ` [PATCH 5/7] mdio_bus: Add mdiobus_get_bus() function Andrey Smirnov
2016-01-26  5:55 ` Andrey Smirnov [this message]
2016-01-26  5:55 ` [PATCH 7/7] commands: Add mdio_read and mdio_write Andrey Smirnov
2016-01-26 21:55   ` Sascha Hauer
2016-01-27  2:09     ` Andrey Smirnov
2016-01-27  2:29       ` Trent Piepho
2016-01-27  7:19         ` Sascha Hauer
2016-01-27  7:26       ` Sascha Hauer
2016-01-28 18:00         ` Andrey Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453787758-12688-6-git-send-email-andrew.smirnov@gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox