From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH v2 6/8] miitool: Don't print negative parent IDs
Date: Sun, 31 Jan 2016 19:10:11 -0800 [thread overview]
Message-ID: <1454296213-12734-7-git-send-email-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <1454296213-12734-1-git-send-email-andrew.smirnov@gmail.com>
Do not include ID of the parent to mii_bus if that ID is negative since
it produces a rather confusing string (e.g. "mdio.11-1", which is very
likely to be interpreted as "mdio.11<dash>1").
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
commands/miitool.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/commands/miitool.c b/commands/miitool.c
index 9ee3597..9ea5ab5 100644
--- a/commands/miitool.c
+++ b/commands/miitool.c
@@ -115,8 +115,9 @@ static int show_basic_mii(struct mii_bus *mii, struct phy_device *phydev,
for (i = 0; i < 32; i++)
mii_val[i] = mii->read(mii, phydev->addr, i);
- printf("%s: %s%d: ", phydev->cdev.name,
- mii->parent->name, mii->parent->id);
+ printf((mii->parent->id) < 0 ? "%s: %s:" : "%s: %s%d: ",
+ phydev->cdev.name, mii->parent->name, mii->parent->id);
+
if (mii_val[MII_BMCR] == 0xffff || mii_val[MII_BMSR] == 0x0000) {
fprintf(stderr, " No MII transceiver present!.\n");
--
2.5.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-02-01 3:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 3:10 [PATCH v2 0/8] Bitbang MDIO, miitool changes Andrey Smirnov
2016-02-01 3:10 ` [PATCH v2 1/8] include/linux/phy.h: Add MII_ADDR_C45 Andrey Smirnov
2016-02-01 3:10 ` [PATCH v2 2/8] net: Port bitbanged MDIO code from Linux kernel Andrey Smirnov
2016-02-01 3:10 ` [PATCH v2 3/8] miitool: Fix PHY argument handling Andrey Smirnov
2016-02-01 3:10 ` [PATCH v2 4/8] mdio_bus: Change dev_info to dev_dbg Andrey Smirnov
2016-02-01 3:10 ` [PATCH v2 5/8] mdio_bus: Add mdiobus_get_bus() function Andrey Smirnov
2016-02-01 3:10 ` Andrey Smirnov [this message]
2016-02-01 3:10 ` [PATCH v2 7/8] mdio_bus: Change PHY's naming scheme Andrey Smirnov
2016-02-03 7:36 ` Sascha Hauer
2016-02-03 19:23 ` Andrey Smirnov
2016-02-04 7:47 ` Sascha Hauer
2016-02-01 3:10 ` [PATCH v2 8/8] miitool: Add code to register a PHY Andrey Smirnov
2016-02-01 9:35 ` Sascha Hauer
2016-02-03 0:41 ` Andrey Smirnov
2016-02-03 7:34 ` Sascha Hauer
2016-02-03 19:20 ` Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454296213-12734-7-git-send-email-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox