mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Trent Piepho <tpiepho@kymetacorp.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>,
	Steffen Trumtrar <s.trumtrar@pengutronix.de>,
	Tim Sander <tim@krieglstein.org>
Subject: Re: [PATCH v4] Terasic DE0-Nano-SoC: add support
Date: Tue, 2 Feb 2016 23:30:15 +0000	[thread overview]
Message-ID: <1454455837.18531.37.camel@rtred1test09.kymeta.local> (raw)
In-Reply-To: <CAHQ1cqEBXBziKFGPaDQBK3zMw0+D4cnjvB2KXHBF906UG8Ahwg@mail.gmail.com>

On Mon, 2016-02-01 at 11:08 -0800, Andrey Smirnov wrote:
> On Mon, Feb 1, 2016 at 8:09 AM, Tim Sander <tim@krieglstein.org> wrote:

> > +
> > +       if (IS_ENABLED(CONFIG_PHYLIB))
> > +               phy_register_fixup_for_uid(PHY_ID_KSZ9021, MICREL_PHY_ID_MASK, phy_fixup);
> 
> I don't think this code is correct. To the best of my knowledge, both
> Atlas and DE0-Nano version of the board come with KSZ9031 as a PHY,
> which requires different fixup. See arm/boards/tqma6x/board.c for
> example.

I think all the fixups for the micrel phys should probably be replaced
with device tree properties.  If you look in drivers/net/phy/micrel.c,
ksz9031_config_init() will read skew properties from the DT and program
the phy that way.  This would make it easier to use the phy DT
properties already in the Linux dts files.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2016-02-02 23:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-01 16:09 Tim Sander
2016-02-01 19:08 ` Andrey Smirnov
2016-02-02  8:03   ` Sascha Hauer
2016-02-02 23:30   ` Trent Piepho [this message]
2016-02-03  1:16     ` Andrey Smirnov
2016-02-11 14:40   ` Tim Sander
2016-02-12  8:33     ` Sascha Hauer
2016-02-12 13:13       ` Tim Sander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454455837.18531.37.camel@rtred1test09.kymeta.local \
    --to=tpiepho@kymetacorp.com \
    --cc=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.trumtrar@pengutronix.de \
    --cc=tim@krieglstein.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox