[PATCH] drivers: video: drop unused of_get_display_timing()

[PATCH] drivers: video: drop unused of_get_display_timing()

[Antony Pavlov]

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
 drivers/video/of_display_timing.c | 25 -------------------------
 1 file changed, 25 deletions(-)

diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c
index eb29ec6..6a5bf62 100644
--- a/drivers/video/of_display_timing.c
+++ b/drivers/video/of_display_timing.c
@@ -99,31 +99,6 @@ static int of_parse_display_timing(const struct device_node *np,
 }
 
 /**
- * of_get_display_timing - parse a display_timing entry
- * @np: device_node with the timing subnode
- * @name: name of the timing node
- * @dt: display_timing struct to fill
- **/
-int of_get_display_timing(struct device_node *np, const char *name,
-		struct fb_videomode *mode)
-{
-	struct device_node *timing_np;
-
-	if (!np)
-		return -EINVAL;
-
-	timing_np = of_get_child_by_name(np, name);
-	if (!timing_np) {
-		pr_err("%s: could not find node '%s'\n",
-			np->full_name, name);
-		return -ENOENT;
-	}
-
-	return of_parse_display_timing(timing_np, mode);
-}
-EXPORT_SYMBOL_GPL(of_get_display_timing);
-
-/**
  * of_get_display_timings - parse all display_timing entries from a device_node
  * @np: device_node with the subnodes
  **/
-- 
2.7.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] drivers: video: drop unused of_get_display_timing()

[Sascha Hauer]

On Thu, Feb 04, 2016 at 12:12:19PM +0300, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
>  drivers/video/of_display_timing.c | 25 -------------------------
>  1 file changed, 25 deletions(-)
> 
> diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c
> index eb29ec6..6a5bf62 100644
> --- a/drivers/video/of_display_timing.c
> +++ b/drivers/video/of_display_timing.c
> @@ -99,31 +99,6 @@ static int of_parse_display_timing(const struct device_node *np,
>  }
>  
>  /**
> - * of_get_display_timing - parse a display_timing entry
> - * @np: device_node with the timing subnode
> - * @name: name of the timing node
> - * @dt: display_timing struct to fill
> - **/
> -int of_get_display_timing(struct device_node *np, const char *name,
> -		struct fb_videomode *mode)

Applied, thanks. of_get_display_timings is the right function to use. If
one wants to use of_get_display_timing he first has to convince us that
he really needs this function.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox