mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] Print error message if of_state_fixup() fails
@ 2016-02-17 18:29 Harald Welte
  2016-02-18 11:58 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Harald Welte @ 2016-02-17 18:29 UTC (permalink / raw)
  To: barebox

If of_state_fixup() fails for some reason, boot/bootm will fail, too

However, it is completely unclear where the error has happened, and to
the user it rather seems like the kernel device tree loaded from some
file was broken/corrupt, not that in fact some fixup routine was
failing.

Adding a meaningful error message can help debugging significantly.

Signed-off-by: Harald Welte <laforge@gnumonks.org>
---
 common/state.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/common/state.c b/common/state.c
index 3e95efd..b55b150 100644
--- a/common/state.c
+++ b/common/state.c
@@ -999,6 +999,7 @@ static int of_state_fixup(struct device_node *root, void *ctx)
 	return 0;
 
  out:
+	dev_err(&state->dev, "error fixing up device tree with boot state\n");
 	of_delete_node(new_node);
 	return ret;
 }
-- 
2.7.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-02-18 11:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-17 18:29 [PATCH] Print error message if of_state_fixup() fails Harald Welte
2016-02-18 11:58 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox