From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from forward14p.cmail.yandex.net ([2a02:6b8:0:1465::be]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1abQAj-0003U4-Hm for barebox@lists.infradead.org; Thu, 03 Mar 2016 10:07:55 +0000 Received: from smtp13.mail.yandex.net (smtp13.mail.yandex.net [IPv6:2a02:6b8:0:801:1::12]) by forward14p.cmail.yandex.net (Yandex) with ESMTP id 3E66920EB8 for ; Thu, 3 Mar 2016 13:07:26 +0300 (MSK) From: Aleksey Kuleshov Date: Thu, 3 Mar 2016 12:58:13 +0300 Message-Id: <1456999094-26928-4-git-send-email-rndfax@yandex.ru> In-Reply-To: <1456999094-26928-1-git-send-email-rndfax@yandex.ru> References: <1456999094-26928-1-git-send-email-rndfax@yandex.ru> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: [PATCH v2 4/5] usb_kbd: use async polling instead of regular polling To: barebox@lists.infradead.org Cc: Aleksey Kuleshov This fixes the overpolling of USB keyboard which causes slowdown of entier barebox by using periodic polling occuting once per some milliseconds. --- drivers/input/usb_kbd.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/input/usb_kbd.c b/drivers/input/usb_kbd.c index 6f7a081..bdaf305 100644 --- a/drivers/input/usb_kbd.c +++ b/drivers/input/usb_kbd.c @@ -48,7 +48,7 @@ struct usb_kbd_pdata; struct usb_kbd_pdata { uint8_t *new; uint8_t old[USB_KBD_BOOT_REPORT_SIZE]; - struct poller_struct poller; + struct poller_async poller; struct usb_device *usbdev; int lock; unsigned long intpipe; @@ -92,10 +92,9 @@ static const unsigned char usb_kbd_keycode[256] = { 150,158,159,128,136,177,178,176,142,152,173,140 }; -static void usb_kbd_poll(struct poller_struct *poller) +static void usb_kbd_poll(void *arg) { - struct usb_kbd_pdata *data = container_of(poller, - struct usb_kbd_pdata, poller); + struct usb_kbd_pdata *data = arg; struct usb_device *usbdev = data->usbdev; int ret, i; @@ -146,6 +145,7 @@ static void usb_kbd_poll(struct poller_struct *poller) exit: data->lock = 0; + poller_call_async(&data->poller, data->intinterval * MSECOND, usb_kbd_poll, data); } static int usb_kbd_probe(struct usb_device *usbdev, @@ -201,16 +201,22 @@ static int usb_kbd_probe(struct usb_device *usbdev, return ret; } - data->poller.func = usb_kbd_poll; + ret = poller_async_register(&data->poller); + if (ret) { + dev_err(&usbdev->dev, "can't setup poller\n"); + return ret; + } + + poller_call_async(&data->poller, data->intinterval * MSECOND, usb_kbd_poll, data); - return poller_register(&data->poller); + return 0; } static void usb_kbd_disconnect(struct usb_device *usbdev) { struct usb_kbd_pdata *data = usbdev->drv_data; - poller_unregister(&data->poller); + poller_async_unregister(&data->poller); input_device_unregister(&data->input); dma_free(data->new); free(data); -- 2.6.2 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox