mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] !fixup driver: replace dev_request_mem_region with dev_request_mem_resource
@ 2016-03-07  4:21 Andrey Smirnov
  2016-03-07  8:14 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Andrey Smirnov @ 2016-03-07  4:21 UTC (permalink / raw)
  To: barebox; +Cc: Andrey Smirnov

It looks like Coccinelle script failed to add register file
initialization code at least in two places

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 drivers/i2c/busses/i2c-imx.c  | 1 +
 drivers/usb/imx/imx-usb-phy.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index 1017971..e407896 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -610,6 +610,7 @@ static int __init i2c_fsl_probe(struct device_d *pdev)
 		ret = PTR_ERR(iores);
 		goto fail;
 	}
+	i2c_fsl->base = IOMEM(iores->start);
 
 	i2c_fsl_init_recovery(i2c_fsl, pdev);
 
diff --git a/drivers/usb/imx/imx-usb-phy.c b/drivers/usb/imx/imx-usb-phy.c
index 3306bd4..33e27da 100644
--- a/drivers/usb/imx/imx-usb-phy.c
+++ b/drivers/usb/imx/imx-usb-phy.c
@@ -76,6 +76,7 @@ static int imx_usbphy_probe(struct device_d *dev)
 		ret = PTR_ERR(iores);
 		goto err_free;
 	}
+	imxphy->base = IOMEM(iores->start);
 
 	imxphy->clk = clk_get(dev, NULL);
 	if (IS_ERR(imxphy->clk)) {
-- 
2.5.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] !fixup driver: replace dev_request_mem_region with dev_request_mem_resource
  2016-03-07  4:21 [PATCH] !fixup driver: replace dev_request_mem_region with dev_request_mem_resource Andrey Smirnov
@ 2016-03-07  8:14 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2016-03-07  8:14 UTC (permalink / raw)
  To: Andrey Smirnov; +Cc: barebox

On Sun, Mar 06, 2016 at 08:21:49PM -0800, Andrey Smirnov wrote:
> It looks like Coccinelle script failed to add register file
> initialization code at least in two places
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  drivers/i2c/busses/i2c-imx.c  | 1 +
>  drivers/usb/imx/imx-usb-phy.c | 1 +
>  2 files changed, 2 insertions(+)

It was missing in far more places. Should be fixed in the newest
version.

Sascha

 
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index 1017971..e407896 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -610,6 +610,7 @@ static int __init i2c_fsl_probe(struct device_d *pdev)
>  		ret = PTR_ERR(iores);
>  		goto fail;
>  	}
> +	i2c_fsl->base = IOMEM(iores->start);
>  
>  	i2c_fsl_init_recovery(i2c_fsl, pdev);
>  
> diff --git a/drivers/usb/imx/imx-usb-phy.c b/drivers/usb/imx/imx-usb-phy.c
> index 3306bd4..33e27da 100644
> --- a/drivers/usb/imx/imx-usb-phy.c
> +++ b/drivers/usb/imx/imx-usb-phy.c
> @@ -76,6 +76,7 @@ static int imx_usbphy_probe(struct device_d *dev)
>  		ret = PTR_ERR(iores);
>  		goto err_free;
>  	}
> +	imxphy->base = IOMEM(iores->start);
>  
>  	imxphy->clk = clk_get(dev, NULL);
>  	if (IS_ERR(imxphy->clk)) {
> -- 
> 2.5.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-03-07  8:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-07  4:21 [PATCH] !fixup driver: replace dev_request_mem_region with dev_request_mem_resource Andrey Smirnov
2016-03-07  8:14 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox