From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Frank Wunderlich <linux@fw-web.de>,
Sascha Hauer <s.hauer@pengutronix.de>
Cc: Frank Wunderlich <frank-w@public-files.de>, barebox@lists.infradead.org
Subject: Re: [PATCH v1] ARM: Rockchip: Add rk3568 BananaPi R2 Pro board support
Date: Mon, 24 Jan 2022 10:12:23 +0100 [thread overview]
Message-ID: <145cf84a-770c-261e-154c-96d82ab5b3a3@pengutronix.de> (raw)
In-Reply-To: <20220123165149.158515-1-linux@fw-web.de>
Hello Frank,
On 23.01.22 17:51, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> +/ {
> + model = "Rockchip RK3568 Bananapi R2 Pro Board";
> + compatible = "rockchip,rk3568-bpi-r2pro", "rockchip,rk3568";
> +
> + aliases {
> + emmc = &sdhci;
> + sd = &sdmmc0;
> + };
> +
> + chosen: chosen {
You can drop the label.
> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
> index 3c6b3dd9b531..7d54f357cfda 100644
> --- a/arch/arm/mach-rockchip/Kconfig
> +++ b/arch/arm/mach-rockchip/Kconfig
> @@ -68,6 +68,12 @@ config MACH_RK3568_EVB
> help
> Say Y here if you are using a RK3568 EVB
>
> +config MACH_RK3568_R2PRO
> + select ARCH_RK3568
> + bool "RK3568 R2PRO"
> + help
> + Say Y here if you are using a RK3568 Bananpi R2 Pro
Banana Pi BPI-R2 Pro*. Perhaps include the Banana Pi bit in the prompt
text as well?
> +
> config MACH_PINE64_QUARTZ64
> select ARCH_RK3568
> bool "Pine64 Quartz64"
> diff --git a/dts/Bindings/arm/rockchip.yaml b/dts/Bindings/arm/rockchip.yaml
> index 4aed16176434..109f885d970f 100644
> --- a/dts/Bindings/arm/rockchip.yaml
> +++ b/dts/Bindings/arm/rockchip.yaml
dts/ is synchronized with Linux, so patches here are not accepted in barebox.
You can add new bindings to Documentation/devicetree/bindings/, although
boards are usually not documented in the bindings, but instead in board
docs:
Could you add an entry to Documentation/boards/rockchip.rst -> Rockchip RK356x
-> Supported Boards?
And enabling the board in arch/arm/configs/rockchip_v8_defconfig
would be nice as well.
Cheers,
Ahmad
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2022-01-24 9:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 16:51 Frank Wunderlich
2022-01-24 8:55 ` Sascha Hauer
2022-01-24 9:11 ` Aw: " Frank Wunderlich
2022-02-10 15:22 ` Frank Wunderlich
2022-02-10 15:55 ` Sascha Hauer
2022-01-24 9:12 ` Ahmad Fatoum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=145cf84a-770c-261e-154c-96d82ab5b3a3@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=frank-w@public-files.de \
--cc=linux@fw-web.de \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox