[PATCH] pinctrl: mxs: add raw value from device tree to debug output

[PATCH] pinctrl: mxs: add raw value from device tree to debug output

[Uwe Kleine-König]

Not sure this is of general interest, but it helped me matching pin
configs from a static table to device tree entries.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/pinctrl/pinctrl-mxs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-mxs.c b/drivers/pinctrl/pinctrl-mxs.c
index ec0aaec67f06..fa1176fe1bd6 100644
--- a/drivers/pinctrl/pinctrl-mxs.c
+++ b/drivers/pinctrl/pinctrl-mxs.c
@@ -89,8 +89,8 @@ static int mxs_pinctrl_set_state(struct pinctrl_device *pdev, struct device_node
 		writel(0x3 << shift, reg + STMP_OFFSET_REG_CLR);
 		writel(muxsel << shift, reg + STMP_OFFSET_REG_SET);
 
-		dev_dbg(iomux->pinctrl.dev, "pin %d, mux %d, ma: %d, vol: %d, pull: %d\n",
-				pinid, muxsel, ma, vol, pull);
+		dev_dbg(iomux->pinctrl.dev, "(val: 0x%x) pin %d, mux %d, ma: %d, vol: %d, pull: %d\n",
+				val, pinid, muxsel, ma, vol, pull);
 
 		/* drive */
 		reg = iomux->base + 0x300;
-- 
2.7.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] pinctrl: mxs: add raw value from device tree to debug output

[Sascha Hauer]

On Fri, Apr 08, 2016 at 09:26:26PM +0200, Uwe Kleine-König wrote:
> Not sure this is of general interest, but it helped me matching pin
> configs from a static table to device tree entries.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/pinctrl/pinctrl-mxs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I think it's interesting enough to have it in the tree. Applied, thanks

Sascha

> 
> diff --git a/drivers/pinctrl/pinctrl-mxs.c b/drivers/pinctrl/pinctrl-mxs.c
> index ec0aaec67f06..fa1176fe1bd6 100644
> --- a/drivers/pinctrl/pinctrl-mxs.c
> +++ b/drivers/pinctrl/pinctrl-mxs.c
> @@ -89,8 +89,8 @@ static int mxs_pinctrl_set_state(struct pinctrl_device *pdev, struct device_node
>  		writel(0x3 << shift, reg + STMP_OFFSET_REG_CLR);
>  		writel(muxsel << shift, reg + STMP_OFFSET_REG_SET);
>  
> -		dev_dbg(iomux->pinctrl.dev, "pin %d, mux %d, ma: %d, vol: %d, pull: %d\n",
> -				pinid, muxsel, ma, vol, pull);
> +		dev_dbg(iomux->pinctrl.dev, "(val: 0x%x) pin %d, mux %d, ma: %d, vol: %d, pull: %d\n",
> +				val, pinid, muxsel, ma, vol, pull);
>  
>  		/* drive */
>  		reg = iomux->base + 0x300;
> -- 
> 2.7.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox