From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.phycard.de ([217.6.246.34] helo=root.phytec.de) by casper.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1b6CTo-0002mI-F1 for barebox@lists.infradead.org; Fri, 27 May 2016 07:46:52 +0000 Received: from idefix.phytec.de (idefix.phytec.de [172.16.0.10]) by root.phytec.de (Postfix) with ESMTP id A9B0EA00B2A for ; Fri, 27 May 2016 09:46:39 +0200 (CEST) From: Teresa Remmet Date: Fri, 27 May 2016 09:44:19 +0200 Message-Id: <1464335095-35180-27-git-send-email-t.remmet@phytec.de> In-Reply-To: <1464335095-35180-1-git-send-email-t.remmet@phytec.de> References: <1464335095-35180-1-git-send-email-t.remmet@phytec.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: [PATCH v2 26/62] UBI: Fastmap: Fix fastmap usage in ubi_volume_notify() To: barebox@lists.infradead.org From: Richard Weinberger There is no need to switch to ro mode if ubi_update_fastmap() fails. Also get rid of the ifdef. Signed-off-by: Richard Weinberger Reviewed-by: Tanya Brokhman Conflicts: drivers/mtd/ubi/build.c Fixed minor conflict. Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/build.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c index 2295c67..b505252 100644 --- a/drivers/mtd/ubi/build.c +++ b/drivers/mtd/ubi/build.c @@ -71,19 +71,21 @@ struct ubi_device *ubi_devices[UBI_MAX_DEVICES]; */ int ubi_volume_notify(struct ubi_device *ubi, struct ubi_volume *vol, int ntype) { + int ret = 0; + #ifdef CONFIG_MTD_UBI_FASTMAP + switch (ntype) { case UBI_VOLUME_ADDED: case UBI_VOLUME_REMOVED: case UBI_VOLUME_RESIZED: case UBI_VOLUME_RENAMED: - if (ubi_update_fastmap(ubi)) { - ubi_err(ubi, "Unable to update fastmap!"); - ubi_ro_mode(ubi); - } + ret = ubi_update_fastmap(ubi); + if (ret) + ubi_msg(ubi, "Unable to write a new fastmap: %i", ret); } #endif - return 0; + return ret; } /** -- 1.9.1 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox