From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1b8KjM-00023M-Uz for barebox@lists.infradead.org; Thu, 02 Jun 2016 04:59:42 +0000 Received: by mail-pf0-x243.google.com with SMTP id f144so6542074pfa.2 for ; Wed, 01 Jun 2016 21:59:20 -0700 (PDT) From: Andrey Smirnov Date: Wed, 1 Jun 2016 21:58:45 -0700 Message-Id: <1464843531-1824-17-git-send-email-andrew.smirnov@gmail.com> In-Reply-To: <1464843531-1824-1-git-send-email-andrew.smirnov@gmail.com> References: <1464843531-1824-1-git-send-email-andrew.smirnov@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: [PATCH v2 16/22] e1000: Remove unnecessary intialization To: barebox@lists.infradead.org Cc: Andrey Smirnov We always call e1000_init_eeprom_params() as a part of probing, so there's no need check if it needs to be called in e1000_read_eeprom(). Signed-off-by: Andrey Smirnov --- drivers/net/e1000/eeprom.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/e1000/eeprom.c b/drivers/net/e1000/eeprom.c index a7059f6..0896fd6 100644 --- a/drivers/net/e1000/eeprom.c +++ b/drivers/net/e1000/eeprom.c @@ -563,10 +563,6 @@ int32_t e1000_read_eeprom(struct e1000_hw *hw, uint16_t offset, DEBUGFUNC(); - /* If eeprom is not yet detected, do so now */ - if (eeprom->word_size == 0) - e1000_init_eeprom_params(hw); - /* A check for invalid values: offset too large, too many words, * and not enough words. */ -- 2.5.5 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox